From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 18 Mar 2011 17:17:54 +0100 (CET) Received: from mail3.caviumnetworks.com ([12.108.191.235]:11348 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491784Ab1CRQRv (ORCPT ); Fri, 18 Mar 2011 17:17:51 +0100 Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378) id ; Fri, 18 Mar 2011 09:18:43 -0700 Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 18 Mar 2011 09:17:47 -0700 Received: from dd1.caveonetworks.com ([12.108.191.236]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 18 Mar 2011 09:17:47 -0700 Message-ID: <4D8385AA.605@caviumnetworks.com> Date: Fri, 18 Mar 2011 09:17:46 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Heiher CC: linux-mips@linux-mips.org Subject: Re: [PATCH] Fixup personality in different ABI. References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 18 Mar 2011 16:17:47.0220 (UTC) FILETIME=[04FD1940:01CBE588] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 29407 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney@caviumnetworks.com Precedence: bulk X-list: linux-mips On 03/17/2011 09:59 PM, Heiher wrote: > Hello, Why, hello to you too. Can you explain what problem you are trying to solve? Presumably if someone has set the personality, they had a reason for doing so. On what grounds do you think it is a good idea to override the explicit desires of the user and restore a default personality? This patch would break many software build systems. Unless you can explain why this is needed, I have to say: NAK to this patch. Thanks, David Daney > >> From bf3637153bc5e3d0e3f1c2982c323057a8e04801 Mon Sep 17 00:00:00 2001 > From: Heiher > Date: Fri, 18 Mar 2011 12:51:08 +0800 > Subject: [PATCH] Fixup personality in different ABI. > > * 'arch' output: > o32 : mips > n32 : mips64 > 64 : mips64 > --- > arch/mips/include/asm/elf.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/mips/include/asm/elf.h b/arch/mips/include/asm/elf.h > index 455c0ac..01510d4 100644 > --- a/arch/mips/include/asm/elf.h > +++ b/arch/mips/include/asm/elf.h > @@ -262,6 +262,7 @@ do { \ > #ifdef CONFIG_MIPS32_N32 > #define __SET_PERSONALITY32_N32() \ > do { \ > + set_personality(PER_LINUX); \ > set_thread_flag(TIF_32BIT_ADDR); \ > current->thread.abi =&mips_abi_n32; \ > } while (0) > @@ -273,6 +274,7 @@ do { \ > #ifdef CONFIG_MIPS32_O32 > #define __SET_PERSONALITY32_O32() \ > do { \ > + set_personality(PER_LINUX32); \ > set_thread_flag(TIF_32BIT_REGS); \ > set_thread_flag(TIF_32BIT_ADDR); \ > current->thread.abi =&mips_abi_32; \ > @@ -305,7 +307,10 @@ do { \ > if ((ex).e_ident[EI_CLASS] == ELFCLASS32) \ > __SET_PERSONALITY32(ex); \ > else \ > + { \ > + set_personality(PER_LINUX); \ > current->thread.abi =&mips_abi; \ > + } \ > \ > p = personality(current->personality); \ > if (p != PER_LINUX32&& p != PER_LINUX) \