Re: [PATCH] xfce_session_4.6.{1, 2}: explicitly pass the path of `iceauth`

From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] xfce_session_4.6.{1, 2}: explicitly pass the path of `iceauth`
Date: Sat, 19 Mar 2011 21:32:31 -0700	[thread overview]
Message-ID: <4D85835F.7070002@gmail.com> (raw)
In-Reply-To: <1300583444.7379.1.camel@mattotaupa>

On 3/19/2011 6:10 PM, Paul Menzel wrote:
> Am Samstag, den 19.03.2011, 11:33 -0700 schrieb Khem Raj:
>> On (18/03/11 13:00), Paul Menzel wrote:
>>> Date: Fri, 18 Mar 2011 12:03:43 +0100
>>>
>>> Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.
>>>
>>>          checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
>>>          checking whether to build with profiling support... no
>>>          checking whether to compile with coverage profiling instrumentation... no
>>>          checking whether to disable assertions... no
>>>          checking whether to build final version... yes
>>>          checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
>>>          checking for iceauth... no
>>>          configure: error: iceauth missing, please check your X11 installation
>>>
>>> As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.
>>>
>>> Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.
>>>
>>> This issue has been reported upstream as ticket #7420 [2].
>>>
>>> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
>>> [2] http://bugzilla.xfce.org/show_bug.cgi?id=7420
>>>
>>> Signed-off-by: Paul Menzel<paulepanter@users.sourceforge.net>
>>> ---
>>>   recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
>>>   recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
>>>   2 files changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
>>> index ba66ac1..5029b21 100644
>>> --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
>>> +++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
>>> @@ -1,13 +1,15 @@
>>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
>>> -DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
>>> +DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
>>>   SECTION = "x11"
>>>
>>> -PR = "r4"
>>> +PR = "r5"
>>>
>>>   inherit xfce46
>>>
>>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
>>>
>>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
>>
>> Would it make sense to have iceauth-native instead ?
>
> It never really executes `iceauth` during compile time but just during
> configure to determine the runtime path. So `iceauth-native` is not
> needed and would be even result in the wrong path, I think.

weather it executes is during configure or during compile how does it 
matter ? in the end it needs iceauth and it will mean that you will ask
folks to have iceauth on their build host which is what I am asking to 
avoid. Either cache the variable or use iceauth-native so this dep is 
removed from build host packages.

>
>>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
>>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
>>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
>>> diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
>>> index d7f768a..c937775 100644
>>> --- a/recipes/xfce-base/xfce4-session_4.6.2.bb
>>> +++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
>>> @@ -1,13 +1,15 @@
>>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
>>> -DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
>>> +DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
>>>   SECTION = "x11"
>>>
>>> -PR = "r0"
>>> +PR = "r1"
>>>
>>>   inherit xfce46
>>>
>>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
>>>
>>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
>>> +
>>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
>>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
>>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
>>> --
>>> 1.7.4.1
>>>
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel