From: Philip Prindeville <philipp_subx@redfish-solutions.com>
To: Netdev <netdev@vger.kernel.org>
Cc: "linux-atm-general@lists.sourceforge.net"
<linux-atm-general@lists.sourceforge.net>
Subject: [PATCH 1/1] solos-pci: Fix regression introduced by newest firmware
Date: Sun, 20 Mar 2011 16:41:40 -0700 [thread overview]
Message-ID: <4D8690B4.7030900@redfish-solutions.com> (raw)
The newest FPGA firmware on the Solos processors correctly signals carrier transitions, bitrate, etc.
The driver previously ignored these messages, and the physical state was always ATM_PHY_SIG_UNKNOWN.
Now that the board reports its state, we expose a bug whereby the transition from UNKNOWN to LOST causes us to release all VC's. It should not: only transitions from FOUND to LOST or UNKNOWN should do this (actually, it's bears examining if the VC's should be released at all).
So we add a check to the previous state on transitions for leaving FOUND state.
Signed-off-by: Philip A Prindeville <philipp@redfish-solutions.com>
---
--- a/drivers/atm/solos-pci.c 2011-03-20 15:27:40.000000000 -0600
+++ b/drivers/atm/solos-pci.c 2011-03-20 16:32:11.000000000 -0600
@@ -382,8 +382,11 @@ static int process_status(struct solos_c
/* Anything but 'Showtime' is down */
if (strcmp(state_str, "Showtime")) {
+ char old_signal = card->atmdev[port]->signal;
+
atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
- atm_dev_release_vccs(card->atmdev[port]);
+ if (old_signal == ATM_PHY_SIG_FOUND)
+ atm_dev_release_vccs(card->atmdev[port]);
dev_info(&card->dev->dev, "Port %d: %s\n", port, state_str);
return 0;
}
reply other threads:[~2011-03-20 23:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8690B4.7030900@redfish-solutions.com \
--to=philipp_subx@redfish-solutions.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.