From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 15/20] video: msm: convert printk to pr_* Date: Mon, 21 Mar 2011 16:33:41 +0300 Message-ID: <4D8753B5.2050401@ru.mvista.com> References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485552-27519-1-git-send-email-carlv@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:63330 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176Ab1CUNfX (ORCPT ); Mon, 21 Mar 2011 09:35:23 -0400 In-Reply-To: <1300485552-27519-1-git-send-email-carlv@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Carl Vanderlip Cc: David Brown , Daniel Walker , Bryan Huntsman , linux-fbdev@vger.kernel.org, Brian Swetland , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Colin Cross , Rebecca Schultz Zavin , Dima Zavin , linux-arm-kernel@lists.infradead.org Hello. Carl Vanderlip wrote: > Reword debugging messages to use pr_err and pr_warning > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 11 ++++------- > 1 files changed, 4 insertions(+), 7 deletions(-) > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 8184ca9..b03204d 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -42,16 +42,13 @@ DEFINE_MUTEX(mdp_mutex); > > static int locked_enable_mdp_irq(struct mdp_info *mdp, uint32_t mask) > { > - int ret = 0; > - > BUG_ON(!mask); > > /* if the mask bits are already set return an error, this interrupt > * is already enabled */ > if (mdp_irq_mask & mask) { > - printk(KERN_ERR "mdp irq already on already on %x %x\n", > - mdp_irq_mask, mask); > - ret = -1; > + pr_err("mdp irq already on %x %x\n", mdp_irq_mask, mask); > + return -1; This change to *return* is not described. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 21 Mar 2011 13:33:41 +0000 Subject: Re: [PATCH 15/20] video: msm: convert printk to pr_* Message-Id: <4D8753B5.2050401@ru.mvista.com> List-Id: References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485552-27519-1-git-send-email-carlv@codeaurora.org> In-Reply-To: <1300485552-27519-1-git-send-email-carlv@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. Carl Vanderlip wrote: > Reword debugging messages to use pr_err and pr_warning > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 11 ++++------- > 1 files changed, 4 insertions(+), 7 deletions(-) > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 8184ca9..b03204d 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -42,16 +42,13 @@ DEFINE_MUTEX(mdp_mutex); > > static int locked_enable_mdp_irq(struct mdp_info *mdp, uint32_t mask) > { > - int ret = 0; > - > BUG_ON(!mask); > > /* if the mask bits are already set return an error, this interrupt > * is already enabled */ > if (mdp_irq_mask & mask) { > - printk(KERN_ERR "mdp irq already on already on %x %x\n", > - mdp_irq_mask, mask); > - ret = -1; > + pr_err("mdp irq already on %x %x\n", mdp_irq_mask, mask); > + return -1; This change to *return* is not described. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Mon, 21 Mar 2011 16:33:41 +0300 Subject: [PATCH 15/20] video: msm: convert printk to pr_* In-Reply-To: <1300485552-27519-1-git-send-email-carlv@codeaurora.org> References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485552-27519-1-git-send-email-carlv@codeaurora.org> Message-ID: <4D8753B5.2050401@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. Carl Vanderlip wrote: > Reword debugging messages to use pr_err and pr_warning > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 11 ++++------- > 1 files changed, 4 insertions(+), 7 deletions(-) > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 8184ca9..b03204d 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -42,16 +42,13 @@ DEFINE_MUTEX(mdp_mutex); > > static int locked_enable_mdp_irq(struct mdp_info *mdp, uint32_t mask) > { > - int ret = 0; > - > BUG_ON(!mask); > > /* if the mask bits are already set return an error, this interrupt > * is already enabled */ > if (mdp_irq_mask & mask) { > - printk(KERN_ERR "mdp irq already on already on %x %x\n", > - mdp_irq_mask, mask); > - ret = -1; > + pr_err("mdp irq already on %x %x\n", mdp_irq_mask, mask); > + return -1; This change to *return* is not described. WBR, Sergei