From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 17/20] video: msm: Prevent framebuffer glitch during initialization Date: Mon, 21 Mar 2011 16:39:57 +0300 Message-ID: <4D87552D.4070205@ru.mvista.com> References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485574-27600-1-git-send-email-carlv@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:51223 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247Ab1CUNlh (ORCPT ); Mon, 21 Mar 2011 09:41:37 -0400 In-Reply-To: <1300485574-27600-1-git-send-email-carlv@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Carl Vanderlip Cc: David Brown , Daniel Walker , Bryan Huntsman , linux-fbdev@vger.kernel.org, Brian Swetland , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Colin Cross , Rebecca Schultz Zavin , Dima Zavin , linux-arm-kernel@lists.infradead.org Hello. Carl Vanderlip wrote: > Holds a reference to the mdp_clk until lateinit, and moves the frambuffer > initialization to device_init. Maybe I'm just blind but I don't see where the patch does the latter... > The framebuffer lcdc driver will grab a > reference to mdp_clk, which prevents the clock from being disabled by > clock_late_init. > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 0bb19fa..b3f334ad 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -38,6 +38,7 @@ struct class *mdp_class; > > static DECLARE_WAIT_QUEUE_HEAD(mdp_ppp_waitqueue); > static unsigned int mdp_irq_mask; > +struct clk *mdp_clk_to_disable_later; Why not just 'mdp_clk'? :-) WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 21 Mar 2011 13:39:57 +0000 Subject: Re: [PATCH 17/20] video: msm: Prevent framebuffer glitch during initialization Message-Id: <4D87552D.4070205@ru.mvista.com> List-Id: References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485574-27600-1-git-send-email-carlv@codeaurora.org> In-Reply-To: <1300485574-27600-1-git-send-email-carlv@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. Carl Vanderlip wrote: > Holds a reference to the mdp_clk until lateinit, and moves the frambuffer > initialization to device_init. Maybe I'm just blind but I don't see where the patch does the latter... > The framebuffer lcdc driver will grab a > reference to mdp_clk, which prevents the clock from being disabled by > clock_late_init. > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 0bb19fa..b3f334ad 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -38,6 +38,7 @@ struct class *mdp_class; > > static DECLARE_WAIT_QUEUE_HEAD(mdp_ppp_waitqueue); > static unsigned int mdp_irq_mask; > +struct clk *mdp_clk_to_disable_later; Why not just 'mdp_clk'? :-) WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Mon, 21 Mar 2011 16:39:57 +0300 Subject: [PATCH 17/20] video: msm: Prevent framebuffer glitch during initialization In-Reply-To: <1300485574-27600-1-git-send-email-carlv@codeaurora.org> References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485574-27600-1-git-send-email-carlv@codeaurora.org> Message-ID: <4D87552D.4070205@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. Carl Vanderlip wrote: > Holds a reference to the mdp_clk until lateinit, and moves the frambuffer > initialization to device_init. Maybe I'm just blind but I don't see where the patch does the latter... > The framebuffer lcdc driver will grab a > reference to mdp_clk, which prevents the clock from being disabled by > clock_late_init. > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 0bb19fa..b3f334ad 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -38,6 +38,7 @@ struct class *mdp_class; > > static DECLARE_WAIT_QUEUE_HEAD(mdp_ppp_waitqueue); > static unsigned int mdp_irq_mask; > +struct clk *mdp_clk_to_disable_later; Why not just 'mdp_clk'? :-) WBR, Sergei