Re: [PATCH 3/6] gathdlc: add mechanism to detect ppp suspension from DUN client.

[Guillaume Zajac <guillaume.zajac@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Hi Denis,

On 17/03/2011 21:13, Denis Kenzior wrote:
> Hi Guillaume,
>
> On 03/15/2011 04:19 AM, Guillaume Zajac wrote:
>> ---
>>   gatchat/gathdlc.c |   58 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 files changed, 58 insertions(+), 0 deletions(-)
> http://en.wikipedia.org/wiki/Time_Independent_Escape_Sequence
>
> If you really want to do this, then lets do this properly, including the
> guard timeouts.
>
> Regards,
> -Denis
>
I noticed also this guard timeouts after having sent the set of patches. 
I will send a 2nd version of patches.
However I can't test the "+++" sequence with telnet because it is adding 
some '\r' '\n' characters when I do do "+++" then "Enter".
I could try to filter those characters but it would add some specific 
code for telnet test case.

I have tried to modifiy gsmdial to send "+++" 5 seconds after the 2 ppp 
devices have been set up for instance.
I have implemented a g_at_ppp_send_escape_sequence() function to send 
it. (this function directly writes on the GIOChannel)
Then the GAtChat is resumed and an ATH0 is sent.

Should I commit first the test case over gsmdial and then commit the 
escape sequence detection mechanism?

Kind regards,
Guillaume