All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Jan Altenberg <jan@linutronix.de>
Cc: bhupesh.sharma@st.com, davem@davemloft.net,
	b.spranger@linutronix.de, netdev@vger.kernel.org
Subject: Re: [PATCH] can: c_can: Do basic c_can configuration _before_ enabling the interrupts
Date: Mon, 21 Mar 2011 17:35:45 +0100	[thread overview]
Message-ID: <4D877E61.5080703@grandegger.com> (raw)
In-Reply-To: <1300715258.2010.30.camel@moestavern>

On 03/21/2011 02:47 PM, Jan Altenberg wrote:
> Hi all,
> 
> I ran into some trouble while testing the SocketCAN driver for the BOSCH
> C_CAN controller. The interface is not correctly initialized, if I put
> some CAN traffic on the line, _while_ the interface is being started
> (which means: the interface doesn't come up correcty, if there's some RX
> traffic while doing 'ifconfig can0 up').
> 
> The current implementation enables the controller interrupts _before_
> doing the basic c_can configuration. I think, this should be done the
> other way round.
> 
> The patch below fixes things for me.
> 
> Signed-off-by: Jan Altenberg <jan@linutronix.de>

Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Thanks,

Wolfgang.

  parent reply	other threads:[~2011-03-21 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 13:47 [PATCH] can: c_can: Do basic c_can configuration _before_ enabling the interrupts Jan Altenberg
2011-03-21 14:49 ` Kurt Van Dijck
2011-03-21 16:35 ` Wolfgang Grandegger [this message]
2011-03-22  1:19   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D877E61.5080703@grandegger.com \
    --to=wg@grandegger.com \
    --cc=b.spranger@linutronix.de \
    --cc=bhupesh.sharma@st.com \
    --cc=davem@davemloft.net \
    --cc=jan@linutronix.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.