From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] fix bugs in temporary mirror layer handling
Date: Tue, 22 Mar 2011 08:42:42 +0100 [thread overview]
Message-ID: <4D8852F2.7020401@redhat.com> (raw)
In-Reply-To: <24010.4646225975$1300623398@news.gmane.org>
Dne 20.3.2011 00:33, Petr Rockai napsal(a):
Just Some minor cosmetics
> while working on vgreduce --removemissing --force, I have uncovered
> about half a dozen bugs in handling mirror image removal with temporary
> layers present in the mirror stack.
>
> The patch did not break any tests from the test suite for me. It is a
> prerequisite for vgreduce --removemissing --force, but it also fixes the
> above bugs when triggered in plain lvconvert and in lvconvert --repair.
>
>
>
> temp-mirror-layer-fixes.diff
>
>
array */
> for (s = mirrored_seg->area_count - 1;
> - s >= 0 && old_area_count - new_area_count < num_removed;
> + s >= 0 && old_area_count - new_area_count < orig_removed;
> s--) {
braces ?
> @@ -825,9 +828,13 @@ static int _remove_mirror_images(struct
> if (!shift_mirror_images(mirrored_seg, s))
> return_0;
> new_area_count--;
> + num_removed ++;
++num_removed
> + ++ retries;
++retries
Zdenek
next parent reply other threads:[~2011-03-22 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <24010.4646225975$1300623398@news.gmane.org>
2011-03-22 7:42 ` Zdenek Kabelac [this message]
2011-03-19 23:33 [PATCH] fix bugs in temporary mirror layer handling Petr Rockai
2011-03-21 21:29 ` Jonathan Brassow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8852F2.7020401@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.