From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] msm: board-msm8960: Add USB peripheral and OTG support Date: Tue, 22 Mar 2011 14:18:49 +0300 Message-ID: <4D888599.4080705@ru.mvista.com> References: <1300783908-4638-1-git-send-email-anjir@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1300783908-4638-1-git-send-email-anjir-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Anji jonnala Cc: bryanh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dwalker-zu3NM2574RrQT0dZR+AlfA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org Hello. On 22-03-2011 11:51, Anji jonnala wrote: > Signed-off-by: Anji jonnala [...] > diff --git a/arch/arm/mach-msm/devices-msm8960.c b/arch/arm/mach-msm/devices-msm8960.c > index 894ff98..8baf4fa 100644 > --- a/arch/arm/mach-msm/devices-msm8960.c > +++ b/arch/arm/mach-msm/devices-msm8960.c [...] > @@ -89,6 +90,52 @@ struct platform_device msm8960_device_uart_gsbi5 = { > .resource = resources_uart_gsbi5, > }; > > +static struct resource resources_otg[] = { > + { > + .start = MSM8960_HSUSB_PHYS, > + .end = MSM8960_HSUSB_PHYS + MSM8960_HSUSB_SIZE, You forgot "- 1". > + .flags = IORESOURCE_MEM, > + }, > + { > + .start = USB1_HS_IRQ, > + .end = USB1_HS_IRQ, > + .flags = IORESOURCE_IRQ, > + }, > +}; > + > +struct platform_device msm_device_otg = { > + .name = "msm_otg", > + .id = -1, > + .num_resources = ARRAY_SIZE(resources_otg), > + .resource = resources_otg, > + .dev = { > + .coherent_dma_mask = 0xffffffff, > + }, > +}; > + > +static struct resource resources_hsusb[] = { > + { > + .start = MSM8960_HSUSB_PHYS, > + .end = MSM8960_HSUSB_PHYS + MSM8960_HSUSB_SIZE, You forgot "- 1" here too. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Tue, 22 Mar 2011 14:18:49 +0300 Subject: [PATCH] msm: board-msm8960: Add USB peripheral and OTG support In-Reply-To: <1300783908-4638-1-git-send-email-anjir@codeaurora.org> References: <1300783908-4638-1-git-send-email-anjir@codeaurora.org> Message-ID: <4D888599.4080705@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 22-03-2011 11:51, Anji jonnala wrote: > Signed-off-by: Anji jonnala [...] > diff --git a/arch/arm/mach-msm/devices-msm8960.c b/arch/arm/mach-msm/devices-msm8960.c > index 894ff98..8baf4fa 100644 > --- a/arch/arm/mach-msm/devices-msm8960.c > +++ b/arch/arm/mach-msm/devices-msm8960.c [...] > @@ -89,6 +90,52 @@ struct platform_device msm8960_device_uart_gsbi5 = { > .resource = resources_uart_gsbi5, > }; > > +static struct resource resources_otg[] = { > + { > + .start = MSM8960_HSUSB_PHYS, > + .end = MSM8960_HSUSB_PHYS + MSM8960_HSUSB_SIZE, You forgot "- 1". > + .flags = IORESOURCE_MEM, > + }, > + { > + .start = USB1_HS_IRQ, > + .end = USB1_HS_IRQ, > + .flags = IORESOURCE_IRQ, > + }, > +}; > + > +struct platform_device msm_device_otg = { > + .name = "msm_otg", > + .id = -1, > + .num_resources = ARRAY_SIZE(resources_otg), > + .resource = resources_otg, > + .dev = { > + .coherent_dma_mask = 0xffffffff, > + }, > +}; > + > +static struct resource resources_hsusb[] = { > + { > + .start = MSM8960_HSUSB_PHYS, > + .end = MSM8960_HSUSB_PHYS + MSM8960_HSUSB_SIZE, You forgot "- 1" here too. WBR, Sergei