From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Pull request (QMP enhancements) Date: Tue, 22 Mar 2011 13:34:58 +0200 Message-ID: <4D888962.3070601@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Dmitry Konishchev Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33361 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754220Ab1CVLfC (ORCPT ); Tue, 22 Mar 2011 07:35:02 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 03/16/2011 12:26 PM, Dmitry Konishchev wrote: > Hi! I use QEMU via QMP and discovered that for some tasks there is no > proper way to do them via QMP. I've written few patches: > * One of them modifies "pci_add" command to return pci address of the > added device, when user hasn't specified it (to be able to delete it > via "pci_del" in the future). > * The second one adds INCOMING_FINISHED QMP event which is emitted > when QEMU finished incoming migration (when started with -incoming > command line option). It is needed because now there is no way to > determine, whether it finished or not, and QMP "cont" command just > returns error. > > Here is the patches: > https://github.com/KonishchevDmitry/qemu-kvm/commit/f7e7119fecbce280e7ee45364260fb6e4d58d49a > https://github.com/KonishchevDmitry/qemu-kvm/commit/97250c2a7eeb1506e0a1517b416046dd02720025 > > It will be awesome if you include this patches to the upstream. > Please post the patches to qemu-devel@nongnu.org (please post patches, not URLs to patches). -- error compiling committee.c: too many arguments to function