From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41821 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q20rp-0002Ak-4Z
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 08:39:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Q20ro-0004xB-5V
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 08:39:20 -0400
Received: from thoth.sbs.de ([192.35.17.2]:25493)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Q20rn-0004wo-QQ
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 08:39:20 -0400
Message-ID: <4D88986F.4070402@siemens.com>
Date: Tue, 22 Mar 2011 13:39:11 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1300200805-13928-1-git-send-email-quintela@redhat.com>	<4D87EC8A.3010309@linux.vnet.ibm.com>
	<4D87FF80.6060300@us.ibm.com>	<4D886BB6.80906@redhat.com>
	<4D8878BE.5070102@linux.vnet.ibm.com>	<4D887CB3.6010505@redhat.com>
	<4D888CFF.5050204@linux.vnet.ibm.com>	<4D888E7F.8040700@linux.vnet.ibm.com>
	<4D888F6A.1000009@siemens.com> <m3vczbwczv.fsf@neno.mitica>
In-Reply-To: <m3vczbwczv.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re:
 [PATCH] Fix migration uint8 arrys handled
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "quintela@redhat.com" <quintela@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@us.ibm.com>, Avi Kivity <avi@redhat.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>

On 2011-03-22 13:33, Juan Quintela wrote:
> Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>>>
>>>          VMSTATE_UINT64_V(pat, CPUState, 13),
>>>
>>
>> Ouch, indeed. Moreover, CPU_SAVE_VERSION was not updated (likely the
>> reason for the breakage). Thanks for debugging this!
>>
>> Anthony (or whoever), please revert this unneeded commit in qemu.git.
>>
>> We had a few migration related regressions recently. Do we have
>> sufficient test cases in autotest for them? Also for migrating from
>> older to the latest version?
> 
> The UINT8 problem was my "brown paper bug" fault.  About autotest, it
> "learnt" to use two machines to test migration a couple of months ago.
> Haven't had the time to write test for it thought.

A basic migrate to file / resume from file on the same host would
already suffice in fact.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux