From: Anthony Liguori <aliguori@us.ibm.com>
To: quintela@redhat.com
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re: [PATCH] Fix migration uint8 arrys handled
Date: Tue, 22 Mar 2011 08:59:40 -0500 [thread overview]
Message-ID: <4D88AB4C.2080001@us.ibm.com> (raw)
In-Reply-To: <m3d3ljjm4k.fsf@neno.mitica>
On 03/22/2011 08:55 AM, Juan Quintela wrote:
> Anthony Liguori<aliguori@us.ibm.com> wrote:
>> On 03/22/2011 07:00 AM, Jan Kiszka wrote:
>>> We had a few migration related regressions recently. Do we have
>>> sufficient test cases in autotest for them? Also for migrating from
>>> older to the latest version?
>> Autotest is too late and also not nearly rigorous enough for what
>> you're trying to catch.
>>
>> Here's how I propose we tackle this. This patch adds a -dump-savevm
>> option that takes a version. It spits out all of the fields we save
>> for a particular version (well, not really, but it should). We also
>> can add type information. The idea is that we'd write a simple test
>> case (using gtester) that ran through and dumped the schema for each
>> version. We'd store the schema's in the tree and the test can compare
>> old schema's to the current schema to check for failure.
>>
>> This was thrown together in just a few minutes. I'll try to put
>> together something more complete later today but I wanted to share
>> this before the call at least.
> This would be an start, althought I still think that a way to dump a
> single device, and a way to dump the state of a device in a specific
> version is needed. Information as:
> - is this always saved
> - size of arrays
> - ....
>
> that is there is not saved.
Yeah, we can add that down the road though. With just something as
simple as this, we can catch quite a few regressions.
Regards,
Anthony Liguori
> Later, Juan.
next prev parent reply other threads:[~2011-03-22 13:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 14:53 [Qemu-devel] [PATCH] Fix migration uint8 arrys handled Juan Quintela
2011-03-18 12:41 ` Yoshiaki Tamura
2011-03-22 0:25 ` Stefan Berger
2011-03-22 1:46 ` Anthony Liguori
2011-03-22 9:28 ` Avi Kivity
2011-03-22 10:23 ` Stefan Berger
2011-03-22 10:40 ` Avi Kivity
2011-03-22 11:50 ` Supsend/resume regression in c995b4 WAS: " Stefan Berger
2011-03-22 11:56 ` Stefan Berger
2011-03-22 12:00 ` Jan Kiszka
2011-03-22 12:21 ` Avi Kivity
2011-03-22 12:30 ` Jan Kiszka
2011-03-22 12:35 ` Avi Kivity
2011-03-22 12:33 ` [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: " Juan Quintela
2011-03-22 12:39 ` Jan Kiszka
2011-03-22 13:26 ` Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] " Anthony Liguori
2011-03-22 13:55 ` [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: " Juan Quintela
2011-03-22 13:59 ` Anthony Liguori [this message]
2011-03-23 9:10 ` Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] " Avi Kivity
2011-03-23 11:22 ` Yoshiaki Tamura
2011-03-23 12:15 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D88AB4C.2080001@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.