From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60399 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q22UG-0004c0-0A for qemu-devel@nongnu.org; Tue, 22 Mar 2011 10:23:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q22UC-0001Gl-NA for qemu-devel@nongnu.org; Tue, 22 Mar 2011 10:23:07 -0400 Received: from cantor.suse.de ([195.135.220.2]:41435 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q22UC-0001GV-Gn for qemu-devel@nongnu.org; Tue, 22 Mar 2011 10:23:04 -0400 Message-ID: <4D88B0C6.6040506@suse.de> Date: Tue, 22 Mar 2011 15:23:02 +0100 From: Alexander Graf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support References: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com> In-Reply-To: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony.perard@citrix.com Cc: Xen Devel , QEMU-devel , Stefano Stabellini On 03/01/2011 07:35 PM, anthony.perard@citrix.com wrote: > From: Anthony PERARD > > Hi all, > > Here is the few change since the V10: > > - Add braces for blocks with single statement in the clean-up patch; > - the patch that builds Xen only for x86 have been removed, instead, > xen_domainbuild is built with libhw and other Xen files are built for i386 > target only; > - the redirection structure with function pointer have been removed, instead, > there are few #define or static inline function use for the compatibility; ARGH! The point of the redirection structure was so I can plug in with xenner and replace all the xen calls with in-qemu versions. If you remove it, I'll have to put it back in in the xenner patch set :(. We need some sort of abstraction between calling xs_ functions and actually calling them. Wrapping all xs_ calls in static inlines would be fine for that, as would the indirect calling table. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support Date: Tue, 22 Mar 2011 15:23:02 +0100 Message-ID: <4D88B0C6.6040506@suse.de> References: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: anthony.perard@citrix.com Cc: Xen Devel , QEMU-devel , Anthony Liguori , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 03/01/2011 07:35 PM, anthony.perard@citrix.com wrote: > From: Anthony PERARD > > Hi all, > > Here is the few change since the V10: > > - Add braces for blocks with single statement in the clean-up patch; > - the patch that builds Xen only for x86 have been removed, instead, > xen_domainbuild is built with libhw and other Xen files are built for i386 > target only; > - the redirection structure with function pointer have been removed, instead, > there are few #define or static inline function use for the compatibility; ARGH! The point of the redirection structure was so I can plug in with xenner and replace all the xen calls with in-qemu versions. If you remove it, I'll have to put it back in in the xenner patch set :(. We need some sort of abstraction between calling xs_ functions and actually calling them. Wrapping all xs_ calls in static inlines would be fine for that, as would the indirect calling table. Alex