All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/3] ipkg: remove legacy staging and install `libipkg.pc` properly
Date: Tue, 22 Mar 2011 15:58:51 +0100	[thread overview]
Message-ID: <4D88B92B.3090703@opendreambox.org> (raw)
In-Reply-To: <1300790542.3827.19.camel@mattotaupa>

Hello Paul,

On 03/22/2011 11:42 AM, Paul Menzel wrote:
> --- a/recipes/ipkg/ipkg_0.99.163.bb
> +++ b/recipes/ipkg/ipkg_0.99.163.bb
> @@ -1,5 +1,5 @@
>  include ipkg.inc
> -PR = "r8"
> +PR = "r9"
>  
>  S = "${WORKDIR}/ipkg-${PV}"
>  
> @@ -12,15 +12,10 @@ SRC_URI = "http://www.handhelds.org/pub/packages/ipkg/ipkg-${PV}.tar.gz \
>  	file://lonk-link-name.patch \
>  	"
>  
> -do_stage() {
> -	oe_libinstall -so libipkg ${STAGING_LIBDIR}
> -	install -d ${STAGING_INCDIR}/libipkg/
> -	for f in *.h
> -	do
> -		install -m 0644 $f ${STAGING_INCDIR}/libipkg/
> -	done
> +do_install () {
> +	install -d ${D}${libdir}/pkgconfig
> +	install -m 0644 ${WORKDIR}/libipkg.pc ${D}${libdir}/pkgconfig/libipkg.pc
>  }

how do the library and headers get installed? Is there a do_install()
inside ipkg.inc? In that case, you should use do_install_append()
instead or move the two new lines to ipkg.inc.

Despite this, I'd prefer moving it to obsolete, too.

Regards,
Andreas



  parent reply	other threads:[~2011-03-22 15:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 10:42 [PATCH 1/3] ipkg: remove legacy staging and install `libipkg.pc` properly Paul Menzel
2011-03-22 10:49 ` [PATCH 1/3 v2] " Paul Menzel
2011-03-22 15:14   ` [PATCH 1/3 v3] " Paul Menzel
2011-03-22 10:56 ` [PATCH 1/3] " Martin Jansa
2011-03-22 11:01   ` Paul Menzel
2011-03-22 11:26     ` Martin Jansa
2011-03-22 14:58 ` Andreas Oberritter [this message]
2011-03-22 15:19   ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D88B92B.3090703@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=paulepanter@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.