Re: [Qemu-devel] [PATCH 02/11] vmstate: register all VMStateDescriptions

[Anthony Liguori <anthony@codemonkey.ws>]

On 03/23/2011 07:30 AM, Peter Maydell wrote:
> On 23 March 2011 00:16, Anthony Liguori<aliguori@us.ibm.com>  wrote:
>> This is a purely mechanical change.
>> +/* Register the VMState Description to support VMState introspection */
>> +static void init_vmstate_description_0(void)
>> +{
>> +    register_vmstate_description(&vmstate_ac97);
>> +}
>> +
>> +vmstate_init(init_vmstate_description_0);
>> +
>> +/* Register the VMState Description to support VMState introspection */
>> +static void init_vmstate_description_0(void)
>> +{
>> +    register_vmstate_description(&vmstate_acpi);
>> +}
>> +
>> +vmstate_init(init_vmstate_description_0);
>> +
> Do we really need five lines of boilerplate for every device?
>
> (I'm wondering if there's some way you could avoid having
> all this for the common case where the vmstate is pointed to
> by the DeviceInfo struct, given that we already register
> all the devices. Failing that, some sort of macro...)

Heh, well that just goes right and head and tremendously simplifies 
everything :-)

There are just a few cases where VMStateDescription is not reachable via 
DeviceInfo so DeviceInfo is definitely the way to go.

Regards,

Anthony Liguori

> -- PMM
>