From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: VMX: simplify NMI mask management
Date: Wed, 23 Mar 2011 16:58:26 +0200
Message-ID: <4D8A0A92.7030105@redhat.com>
References: <1300885976-8755-1-git-send-email-avi@redhat.com> <4D8A098D.5070902@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:60631 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932941Ab1CWO6i (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 23 Mar 2011 10:58:38 -0400
In-Reply-To: <4D8A098D.5070902@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 03/23/2011 04:54 PM, Jan Kiszka wrote:
> >  @@ -3991,9 +3987,7 @@ static void __vmx_complete_interrupts(struct vcpu_vmx *vmx,
> >   		* Clear bit "block by NMI" before VM entry if a NMI
> >   		* delivery faulted.
> >   		*/
> >  -		vmcs_clear_bits(GUEST_INTERRUPTIBILITY_INFO,
> >  -				GUEST_INTR_STATE_NMI);
> >  -		vmx->nmi_known_unmasked = true;
> >  +		vmx_set_nmi_mask(&vmx->vcpu, false);
> >   		break;
> >   	case INTR_TYPE_SOFT_EXCEPTION:
> >   		vmx->vcpu.arch.event_exit_inst_len =
>
> Looks consistent to me, but maybe you should update the comment above
> that's now also applied to the emulated mask.

In what way?

         /*
          * SDM 3: 27.7.1.2 (September 2008)
          * Clear bit "block by NMI" before VM entry if a NMI
          * delivery faulted.
          */

Seems pretty descriptive.

-- 
error compiling committee.c: too many arguments to function