From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 1/6] Pool locking code
Date: Wed, 23 Mar 2011 20:01:17 +0100 [thread overview]
Message-ID: <4D8A437D.9080609@redhat.com> (raw)
In-Reply-To: <1300905681.25951.3.camel@ubuntu>
Dne 23.3.2011 19:41, Joe Thornber napsal(a):
> On Wed, 2011-03-23 at 16:57 +0100, Zdenek Kabelac wrote:
>> If there would be just 1 vg read for 7200 activate call - obviously
>> I'd not
>> need to play with this dm_pool locking :)
>>
>> So there is 7200 vg reads - which will use this one locked pool with
>> my patch set:
>
> ok, so I'm playing catch-up; This locking functionality is debug only.
> In the near term the set/restore api wont be needed at all, at which
> point that interface can be removed. We should leave the locking side
> for regression tests.
Yes - the locking has rather 'debug' semantic to catch writes to vg mempool.
But I'm not sure what do you mean here by 'set/restore api won't be needed' ?
As currently I need to restore the content of the modified part of mempool to
return always the same memory like it would be created 1st time.
(Unless you mean here, that you would rather change the code which modifies
lv/vg->status - so these flag would not need to be restored - which would be a
nice option - but would certainly require bigger modification of the code.)
Zdenek
next prev parent reply other threads:[~2011-03-23 19:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 21:21 [PATCH 0/6] VG share v2 Zdenek Kabelac
2011-03-22 21:21 ` [PATCH 1/6] Pool locking code Zdenek Kabelac
2011-03-23 14:03 ` Joe Thornber
2011-03-23 14:43 ` Zdenek Kabelac
2011-03-23 14:53 ` Joe Thornber
2011-03-23 14:54 ` Zdenek Kabelac
2011-03-23 15:13 ` Joe Thornber
2011-03-23 15:57 ` Zdenek Kabelac
2011-03-23 16:33 ` Zdenek Kabelac
2011-03-23 17:29 ` Zdenek Kabelac
2011-03-23 18:41 ` Joe Thornber
2011-03-23 19:01 ` Zdenek Kabelac [this message]
2011-03-24 12:21 ` Joe Thornber
2011-03-24 12:45 ` Zdenek Kabelac
2011-03-24 13:50 ` Zdenek Kabelac
2011-03-22 21:21 ` [PATCH 2/6] Code move vg_mark_partial up in stack Zdenek Kabelac
2011-03-22 21:21 ` [PATCH 3/6] Share VG multiple times Zdenek Kabelac
2011-03-22 21:21 ` [PATCH 4/6] Use dm_pool_set_uint64 Zdenek Kabelac
2011-03-22 21:21 ` [PATCH 5/6] lv_postorder using dm_pool_set_uint64 Zdenek Kabelac
2011-03-22 21:22 ` [PATCH 6/6] lv_postorder unlock and lock Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A437D.9080609@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.