From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/3] hwmon: (f71882fg) Secure chip property
Date: Thu, 24 Mar 2011 08:13:02 +0000 [thread overview]
Message-ID: <4D8AFD0E.5020900@redhat.com> (raw)
In-Reply-To: <20110323214702.69fa03ac@endymion.delvare>
Hi,
I like.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
On 03/23/2011 09:47 PM, Jean Delvare wrote:
> Using C99-style array initialization will ensure definitions won't
> drift if the chips enum gets new values added.
>
> Signed-off-by: Jean Delvare<khali@linux-fr.org>
> Cc: Hans de Goede<hdegoede@redhat.com>
> ---
> drivers/hwmon/f71882fg.c | 48 +++++++++++++++++++++++-----------------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> --- linux-2.6.39-rc0.orig/drivers/hwmon/f71882fg.c 2011-03-23 10:34:23.000000000 +0100
> +++ linux-2.6.39-rc0/drivers/hwmon/f71882fg.c 2011-03-23 14:53:29.000000000 +0100
> @@ -120,36 +120,36 @@ static const char *f71882fg_names[] = {
> };
>
> static const char f71882fg_has_in[8][F71882FG_MAX_INS] = {
> - { 1, 1, 1, 1, 1, 1, 0, 1, 1 }, /* f71808e */
> - { 1, 1, 1, 0, 0, 0, 0, 0, 0 }, /* f71858fg */
> - { 1, 1, 1, 1, 1, 1, 1, 1, 1 }, /* f71862fg */
> - { 1, 1, 1, 1, 1, 1, 1, 1, 1 }, /* f71869 */
> - { 1, 1, 1, 1, 1, 1, 1, 1, 1 }, /* f71882fg */
> - { 1, 1, 1, 1, 1, 1, 1, 1, 1 }, /* f71889fg */
> - { 1, 1, 1, 1, 1, 1, 1, 1, 1 }, /* f71889ed */
> - { 1, 1, 1, 0, 0, 0, 0, 0, 0 }, /* f8000 */
> + [f71808e] = { 1, 1, 1, 1, 1, 1, 0, 1, 1 },
> + [f71858fg] = { 1, 1, 1, 0, 0, 0, 0, 0, 0 },
> + [f71862fg] = { 1, 1, 1, 1, 1, 1, 1, 1, 1 },
> + [f71869] = { 1, 1, 1, 1, 1, 1, 1, 1, 1 },
> + [f71882fg] = { 1, 1, 1, 1, 1, 1, 1, 1, 1 },
> + [f71889fg] = { 1, 1, 1, 1, 1, 1, 1, 1, 1 },
> + [f71889ed] = { 1, 1, 1, 1, 1, 1, 1, 1, 1 },
> + [f8000] = { 1, 1, 1, 0, 0, 0, 0, 0, 0 },
> };
>
> static const char f71882fg_has_in1_alarm[8] = {
> - 0, /* f71808e */
> - 0, /* f71858fg */
> - 0, /* f71862fg */
> - 0, /* f71869 */
> - 1, /* f71882fg */
> - 1, /* f71889fg */
> - 1, /* f71889ed */
> - 0, /* f8000 */
> + [f71808e] = 0,
> + [f71858fg] = 0,
> + [f71862fg] = 0,
> + [f71869] = 0,
> + [f71882fg] = 1,
> + [f71889fg] = 1,
> + [f71889ed] = 1,
> + [f8000] = 0,
> };
>
> static const char f71882fg_has_beep[8] = {
> - 0, /* f71808e */
> - 0, /* f71858fg */
> - 1, /* f71862fg */
> - 1, /* f71869 */
> - 1, /* f71882fg */
> - 1, /* f71889fg */
> - 1, /* f71889ed */
> - 0, /* f8000 */
> + [f71808e] = 0,
> + [f71858fg] = 0,
> + [f71862fg] = 1,
> + [f71869] = 1,
> + [f71882fg] = 1,
> + [f71889fg] = 1,
> + [f71889ed] = 1,
> + [f8000] = 0,
> };
>
> static struct platform_device *f71882fg_pdev;
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2011-03-24 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 20:47 [lm-sensors] [PATCH 1/3] hwmon: (f71882fg) Secure chip property Jean Delvare
2011-03-24 3:30 ` Guenter Roeck
2011-03-24 8:13 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8AFD0E.5020900@redhat.com \
--to=hdegoede@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.