From: Mohammed Shafi <mshajakhan@atheros.com>
To: Sujith <m.sujith@gmail.com>
Cc: Mohammed Shajakhan <Mohammed.Shajakhan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH] ath9k: cleanup few redundant macros
Date: Thu, 24 Mar 2011 15:16:54 +0530 [thread overview]
Message-ID: <4D8B130E.6090307@atheros.com> (raw)
In-Reply-To: <19851.4373.967588.536327@gargle.gargle.HOWL>
On Thursday 24 March 2011 03:08 PM, Sujith wrote:
> Mohammed Shafi Shajakhan wrote:
>
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>> ---
>> drivers/net/wireless/ath/ath9k/ath9k.h | 4 ----
>> drivers/net/wireless/ath/ath9k/common.c | 2 +-
>> drivers/net/wireless/ath/ath9k/mac.c | 2 --
>> 3 files changed, 1 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
>> index 099bd41..24b747c 100644
>> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
>> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
>> @@ -120,13 +120,11 @@ void ath_descdma_cleanup(struct ath_softc *sc, struct ath_descdma *dd,
>> /* RX / TX */
>> /***********/
>>
>> -#define ATH_MAX_ANTENNA 3
>> #define ATH_RXBUF 512
>> #define ATH_TXBUF 512
>> #define ATH_TXBUF_RESERVE 5
>> #define ATH_MAX_QDEPTH (ATH_TXBUF / 4 - ATH_TXBUF_RESERVE)
>> #define ATH_TXMAXTRY 13
>> -#define ATH_MGT_TXMAXTRY 4
>>
>> #define TID_TO_WME_AC(_tid) \
>> ((((_tid) == 0) || ((_tid) == 3)) ? WME_AC_BE : \
>> @@ -688,8 +686,6 @@ void ath9k_ps_restore(struct ath_softc *sc);
>>
>> u8 ath_txchainmask_reduction(struct ath_softc *sc, u8 chainmask, u32 rate);
>>
>> -void ath9k_set_bssid_mask(struct ieee80211_hw *hw, struct ieee80211_vif *vif);
>> -
>> void ath_start_rfkill_poll(struct ath_softc *sc);
>> extern void ath9k_rfkill_poll_state(struct ieee80211_hw *hw);
>> void ath9k_calculate_iter_data(struct ieee80211_hw *hw,
>> diff --git a/drivers/net/wireless/ath/ath9k/common.c b/drivers/net/wireless/ath/ath9k/common.c
>> index 615e682..16ba8c6 100644
>> --- a/drivers/net/wireless/ath/ath9k/common.c
>> +++ b/drivers/net/wireless/ath/ath9k/common.c
>> @@ -116,7 +116,7 @@ void ath9k_cmn_update_ichannel(struct ath9k_channel *ichan,
>>
>> if (chan->band == IEEE80211_BAND_2GHZ) {
>> ichan->chanmode = CHANNEL_G;
>> - ichan->channelFlags = CHANNEL_2GHZ | CHANNEL_OFDM | CHANNEL_G;
>> + ichan->channelFlags = CHANNEL_2GHZ | CHANNEL_OFDM;
>>
> There's a reason for this: 8813262ea79acf9daa0e03901bdfe93db4dc4ca5
> If channel handling has been cleaned up since then, this can be removed.
>
Oh Ok thanks, I will resend the patch without that change.
but anyway CHANNEL_G is defined as (CHANNEL_2GHZ|CHANNEL_OFDM).
Please tell me what I am missing.
> Sujith
> .
>
>
next prev parent reply other threads:[~2011-03-24 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 9:06 [PATCH] ath9k: cleanup few redundant macros Mohammed Shafi Shajakhan
2011-03-24 9:38 ` Sujith
2011-03-24 9:46 ` Mohammed Shafi [this message]
2011-03-24 9:48 ` Mohammed Shafi
2011-03-24 10:02 ` Sujith
2011-03-24 10:10 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8B130E.6090307@atheros.com \
--to=mshajakhan@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Mohammed.Shajakhan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.sujith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.