From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v2] can: c_can: disable one shot mode until driver is fixed Date: Thu, 24 Mar 2011 12:56:19 +0100 Message-ID: <4D8B3163.8080706@grandegger.com> References: <1300964453-2634-1-git-send-email-mkl@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jan-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org To: Marc Kleine-Budde Return-path: In-Reply-To: <1300964453-2634-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On 03/24/2011 12:00 PM, Marc Kleine-Budde wrote: > This patch disables the one shot mode, until the driver has been fixed and > tested to support it. > >> I'm quite sure I've seen a situation where msg_obj 17 "seemed" to be >> pending, while msg_obj 18 and 19 already have been transmitted. But >> in that case, I enabled ONESHOT for the can interface, which enables >> the DA mode (automatic retransmission is disabled). > > Reported-by: Jan Altenberg > Signed-off-by: Marc Kleine-Budde > Signed-off-by: Kurt Van Dijck > Cc: Bhupesh Sharma Acked-by: Wolfgang Grandegger I agree, ONESHOT mode is tricky and needs more thoughts and testing. I remember some ugly principle problems with the MCP251x. Wolfgang.