From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH/RFC 07/19] OMAP3: voltage: add scalable flag to voltagedomain Date: Thu, 24 Mar 2011 15:54:28 +0100 Message-ID: <4D8B5B24.40807@ti.com> References: <1300924833-26745-1-git-send-email-khilman@ti.com> <1300924833-26745-8-git-send-email-khilman@ti.com> <8989339cfa18407f4caacb718eec831d@mail.gmail.com> <87wrjo1uax.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:48519 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564Ab1CXOyf (ORCPT ); Thu, 24 Mar 2011 10:54:35 -0400 In-Reply-To: <87wrjo1uax.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Hilman, Kevin" Cc: "Sripathy, Vishwanath" , "linux-omap@vger.kernel.org" , Paul Walmsely On 3/24/2011 3:12 PM, Hilman, Kevin wrote: > Vishwanath Sripathy writes: > >>> -----Original Message----- >>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- >>> owner@vger.kernel.org] On Behalf Of Kevin Hilman >>> Sent: Thursday, March 24, 2011 5:30 AM >>> To: linux-omap@vger.kernel.org >>> Cc: Paul Walmsely; Benoit Cousson >>> Subject: [PATCH/RFC 07/19] OMAP3: voltage: add scalable flag to >>> voltagedomain >>> >>> Add a 'bool scalable' flag to the struct powerdomain and set it for >> >> I suppose you meant "struct voltagedomain". > > yes > >> But shouldn't this flag be part of PMIC struct? >> Voltage scalability depends on the kind of VDD supply from PMIC. So even >> if OMAP supports voltage scaling, we may not be able to scale the voltage >> if PMIC does not support it. > > That's a good point. Probably I can drop this flag and just use the > existence of the various fields of the voltage domain (pmic, vc, vp, > etc.) to determine if the voltdm can scale. Mmm, the scalability is still a characteristic of the OMAP voltage domain. Some are scalable with a supported range of voltage, some are not. So that information is relevant in the voltage domain. Then the regulator framework will have as well some information about the range that should match what OMAP is able to do. Benoit