All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Huang Weiyi <weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH 4/4] can: c_can: remove duplicated #include
Date: Thu, 24 Mar 2011 17:15:50 +0100	[thread overview]
Message-ID: <4D8B6E36.601@grandegger.com> (raw)
In-Reply-To: <1300457247-2652-1-git-send-email-weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 03/18/2011 03:07 PM, Huang Weiyi wrote:
> Remove duplicated #include('s) in
>   drivers/net/can/c_can/c_can.c
>   drivers/net/can/c_can/c_can_platform.c
> 
> Signed-off-by: Huang Weiyi <weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/net/can/c_can/c_can.c          |    1 -
>  drivers/net/can/c_can/c_can_platform.c |    1 -
>  2 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
> index 1405078..b343bcb 100644
> --- a/drivers/net/can/c_can/c_can.c
> +++ b/drivers/net/can/c_can/c_can.c
> @@ -34,7 +34,6 @@
>  #include <linux/if_arp.h>
>  #include <linux/if_ether.h>
>  #include <linux/list.h>
> -#include <linux/delay.h>
>  #include <linux/io.h>
>  
>  #include <linux/can.h>
> diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c
> index e629b96..61c41ba 100644
> --- a/drivers/net/can/c_can/c_can_platform.c
> +++ b/drivers/net/can/c_can/c_can_platform.c
> @@ -28,7 +28,6 @@
>  #include <linux/if_arp.h>
>  #include <linux/if_ether.h>
>  #include <linux/list.h>
> -#include <linux/delay.h>
>  #include <linux/io.h>
>  #include <linux/platform_device.h>
>  #include <linux/clk.h>

Acked-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>

I added a CC to the netdev mailing list. Hope that's sufficient to get
the patch accepted.

Thanks,

Wolfgang.

       reply	other threads:[~2011-03-24 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1300457247-2652-1-git-send-email-weiyi.huang@gmail.com>
     [not found] ` <1300457247-2652-1-git-send-email-weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-03-24 16:15   ` Wolfgang Grandegger [this message]
     [not found]     ` <4D8B6E36.601-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-03-28  1:24       ` [PATCH 4/4] can: c_can: remove duplicated #include David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8B6E36.601@grandegger.com \
    --to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
    --cc=Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    --cc=weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.