From: Benny Halevy <bhalevy@panasas.com>
To: "William A. (Andy) Adamson" <androsadamson@gmail.com>
Cc: Fred Isaman <iisaman@netapp.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 11/12] NFSv4.1: layoutcommit
Date: Thu, 24 Mar 2011 19:06:07 +0200 [thread overview]
Message-ID: <4D8B79FF.8060906@panasas.com> (raw)
In-Reply-To: <AANLkTi=S+gQER_upORoaK6WSMp8++25W6pTDpR7MD9Ec@mail.gmail.com>
On 2011-03-24 16:45, William A. (Andy) Adamson wrote:
> Hi Benny
>
> int sync is used because the struct writeback_control->sync_mode (an
> enum) is assigned.
Then the compiler will do the assignment into bool once (I hope it
optimizes for the enum values which are {0,1}) and thereafter use the
bool value.
Benny
>
> -->Andy
>
>>> +pnfs_layoutcommit_inode(struct inode *inode, int sync)
>>
>> "bool sync" makes more sense
next prev parent reply other threads:[~2011-03-24 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 14:45 [PATCH 11/12] NFSv4.1: layoutcommit William A. (Andy) Adamson
2011-03-24 17:06 ` Benny Halevy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-24 13:57 William A. (Andy) Adamson
2011-03-24 16:37 ` Benny Halevy
2011-03-24 16:48 ` Trond Myklebust
2011-03-24 16:54 ` Fred Isaman
2011-03-24 16:58 ` Benny Halevy
2011-03-24 17:15 ` Trond Myklebust
2011-03-25 9:39 ` Benny Halevy
2011-03-23 13:27 [PATCH 00/12] NFSv4.1 pnfs wave5 submission (try 2) Fred Isaman
2011-03-23 13:27 ` [PATCH 11/12] NFSv4.1: layoutcommit Fred Isaman
2011-03-23 20:33 ` Benny Halevy
2011-03-23 21:00 ` Christoph Hellwig
2011-03-23 21:15 ` Trond Myklebust
2011-03-23 21:21 ` Christoph Hellwig
2011-03-23 21:26 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8B79FF.8060906@panasas.com \
--to=bhalevy@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=androsadamson@gmail.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.