From: Jiri Slaby <jslaby@suse.cz>
To: Greg KH <gregkh@suse.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Should .dtr_rts do tty_port_tty_get?
Date: Fri, 25 Mar 2011 11:45:39 +0100 [thread overview]
Message-ID: <4D8C7253.3040204@suse.cz> (raw)
Hi,
I'm playing with a serial device and got a nice oops. Maybe after some
weird stty's, I don't know. But it dies in uart_dtr_rts:
.loc 1 1535 0
movq (%rbx), %r13 # port_1(D)->tty, D.26746
...
.loc 1 1494 0
testb $2, 224(%r13) #, D.26746_10->flags
^^^^^^^^^
HERE
Because r13 (port->tty) is NULL. So the question is about the principle.
Should it call tty_port_tty_get or is it a bug in the TTY layer and
uart_dtr_rts should not be called with port->tty == NULL?
I'll attach a patch which does the former as a reply to this message.
BTW only serial_core needs tty in dtr_rts.
thanks,
--
js
suse labs
next reply other threads:[~2011-03-25 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 10:45 Jiri Slaby [this message]
2011-03-25 10:45 ` [PATCH 1/1] TTY: serial_core, fix dtr_rts NULL dereference Jiri Slaby
2011-03-25 11:00 ` Alan Cox
2011-03-25 14:43 ` Jiri Slaby
2011-03-25 20:49 ` Alan Cox
2011-03-29 15:10 ` Jiri Slaby
2011-03-29 22:10 ` [PATCH 1/3] serial: core, move termios handling to uart_startup Jiri Slaby
2011-03-29 22:10 ` [PATCH 2/3] serial: core, do not set DTR/RTS twice on startup Jiri Slaby
2011-03-29 22:10 ` [PATCH 3/3] serial: core, remove uart_update_termios Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8C7253.3040204@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.