From: Anthony Liguori <aliguori@us.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Ulrich Obergfell <uobergfe@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] severe memory leak caused by broken palette_destroy() function
Date: Fri, 25 Mar 2011 07:36:43 -0500 [thread overview]
Message-ID: <4D8C8C5B.5080807@us.ibm.com> (raw)
In-Reply-To: <AANLkTimUt3_H4a2K5RwoxNAA=SfMyb23geLPCr+Y2U0P@mail.gmail.com>
On 03/25/2011 04:31 AM, Stefan Hajnoczi wrote:
> On Fri, Mar 25, 2011 at 8:45 AM, Ulrich Obergfell<uobergfe@redhat.com> wrote:
>> This is version 2 of the patch that I originally posted in:
>>
>> http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg02063.html
>>
>> [Sorry, I missed to include the keyword 'PATCH' in the subject
>> of the original post.]
>>
>> The following commit breaks the code of the function palette_destroy().
>>
>> http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268
>>
>> The broken code causes a severe memory leak of 'VncPalette' structures
>> because it never frees anything:
>>
>> 70 void palette_destroy(VncPalette *palette)
>> 71 {
>> 72 if (palette == NULL) {
>> 73 qemu_free(palette);
>> 74 }
>> 75 }
>>
>> Version 2 of the patch calls qemu_free() unconditionally.
>>
>> Signed-off-by: Ulrich Obergfell<uobergfe@redhat.com>
> Looks good.
Applied. Thanks.
Regards,
Anthony Liguori
> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2011-03-25 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <942456759.505022.1301042552254.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2011-03-25 8:45 ` [Qemu-devel] [PATCH v2] severe memory leak caused by broken palette_destroy() function Ulrich Obergfell
2011-03-25 9:28 ` [Qemu-devel] " Juan Quintela
2011-03-25 9:31 ` [Qemu-devel] " Stefan Hajnoczi
2011-03-25 12:36 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8C8C5B.5080807@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.