All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: WARNING: at kernel/timer.c:1012 del_timer_sync+0x39/0x4e()
Date: Fri, 25 Mar 2011 14:01:10 +0000	[thread overview]
Message-ID: <4D8CA026.9000002@goop.org> (raw)
In-Reply-To: <4D8C9004.6080804@kernel.dk>

On 03/25/2011 12:52 PM, Jens Axboe wrote:
>> How should this be fixed? Is this call to blk_stop_queue() bogus, or is
>> it OK to call it in a handler like this?  If so, is the warning itself
>> wrong?
> Calling it in there should be fine, the problem is that the work cancel
> turns into a sync timer delete. That is not needed. Can you try the
> below?

Yep, that works.  Tested-by: Jeremy Fitzhardinge
<jeremy.fitzhardinge@citrix.com>

>> Does this relate to  7eaceaccab5f4 "block: remove per-queue plugging"?
> No

OK.  Is the correct fix for that change to just remove all the
plug/unplug code?  We have some still out-of-tree code that stopped
compiling.

Thanks,
    J

      reply	other threads:[~2011-03-25 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25 12:28 WARNING: at kernel/timer.c:1012 del_timer_sync+0x39/0x4e() Jeremy Fitzhardinge
2011-03-25 12:52 ` Jens Axboe
2011-03-25 14:01   ` Jeremy Fitzhardinge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8CA026.9000002@goop.org \
    --to=jeremy@goop.org \
    --cc=Xen-devel@lists.xensource.com \
    --cc=axboe@kernel.dk \
    --cc=konrad.wilk@oracle.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.