All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Mahadeva, Avinash" <avinashhm@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Nayak, Rajendra" <rnayak@ti.com>,
	"Hilman, Kevin" <khilman@ti.com>
Subject: Re: [PATCH] omap: hwmod: add syss reset done flags to omap2, omap3 hwmods
Date: Fri, 25 Mar 2011 15:42:12 +0100	[thread overview]
Message-ID: <4D8CA9C4.3060504@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103242336410.21987@utopia.booyaka.com>

Hi Paul,

On 3/25/2011 6:38 AM, Paul Walmsley wrote:
> Hi Avinash,
>
>>> On Thu, 24 Feb 2011, Avinash.H.M wrote:
>>>
>>>> Some of the omap2, omap3 peripherals support software reset. This
>>>> can be done through the softreset bit in sysconfig register.
>>>> The reset status can be checked through resetdone bit of
>>>> sysstatus register. syss_has_reset_status is added to the hwmod
>>>> database of peripherals which have resetdone bit in sysstatus register.
>>>>
>>>> Cc: Rajendra Nayak<rnayak@ti.com>
>>>> Cc: Paul Walmsley<paul@pwsan.com>
>>>> Cc: Benoit Cousson<b-cousson@ti.com>
>>>> Cc: Kevin Hilman<khilman@ti.com>
>>>> Reviewed-by: Govindraj.R<govindraj.raja@ti.com>
>>>> Signed-off-by: Avinash.H.M<avinashhm@ti.com>
>
> This patch is causing I2C softreset timeouts in the hwmod layer on OMAP2
> and 3.  Could you please take a look at this and figure out what is going
> on?

I think this is probably due to the nasty I2C softreset bug with 
discussed last year with Paul Brady.

AFAIR, the I2C cannot be reset by just writing to the SYSCONFIG 
softreset bit. You need to play with other registers too.

Avinash,
You should try to look at 3430 or 3630 errata. You will probably find 
the bug I'm referring to.


Benoit


  parent reply	other threads:[~2011-03-25 14:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 10:08 [PATCH] omap: hwmod: add syss reset done flags to omap2, omap3 hwmods Avinash.H.M
2011-03-03 21:28 ` Paul Walmsley
2011-03-14 16:16   ` Avinash.H.M.
2011-03-25  5:38     ` Paul Walmsley
2011-03-25  6:26       ` Avinash.H.M.
2011-03-25  7:20         ` Avinash.H.M.
2011-03-25 17:24           ` Paul Walmsley
2011-03-26 11:35             ` Avinash.H.M.
2011-03-26 19:38               ` Paul Walmsley
2011-03-31 14:40               ` Avinash.H.M.
2011-03-31 15:04                 ` Kevin Hilman
2011-03-31 15:51                   ` Avinash.H.M.
2011-03-31 15:56                     ` Cousson, Benoit
2011-03-31 16:22                       ` Avinash.H.M.
2011-03-25 14:42       ` Cousson, Benoit [this message]
2011-03-25 17:23         ` Paul Walmsley
2011-03-26 11:31           ` Avinash.H.M.
2011-03-31 13:06             ` Avinash.H.M.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8CA9C4.3060504@ti.com \
    --to=b-cousson@ti.com \
    --cc=avinashhm@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.