From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset
Date: Fri, 25 Mar 2011 12:43:41 -0300 [thread overview]
Message-ID: <4D8CB82D.2000405@freescale.com> (raw)
In-Reply-To: <20110317161047.GO13316@pengutronix.de>
Hi Sascha,
On 3/17/2011 1:10 PM, Uwe Kleine-K?nig wrote:
> On Thu, Mar 17, 2011 at 12:55:57PM -0300, Fabio Estevam wrote:
>> Current code inside babbage_usbhub_reset uses gpio_direction_output with initial value of the GPIO and also sets
>> the GPIO value via gpio_set_value to the same level right after. This is not needed.
>>
>> By using gpio_request_one it is possible to set the direction and initial value in one shot.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
On your i.MX pull request of today I didn?t see this patch applied.
Is there any problem with this one?
Thanks,
Fabio Estevam
prev parent reply other threads:[~2011-03-25 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 15:55 [PATCH v2 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Fabio Estevam
2011-03-17 15:55 ` [PATCH v2 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
2011-03-17 15:55 ` [PATCH v2 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset Fabio Estevam
2011-03-17 15:55 ` [PATCH v2 4/4] ARM: mx5/mx53_evk: Make the reset pin name more meaningful Fabio Estevam
2011-03-17 16:10 ` [PATCH v2 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Uwe Kleine-König
2011-03-25 15:43 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8CB82D.2000405@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.