From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] dun: Add ATX command in emulator (X0 only)
Date: Fri, 25 Mar 2011 12:36:27 -0500 [thread overview]
Message-ID: <4D8CD29B.70500@gmail.com> (raw)
In-Reply-To: <1300980591-9395-1-git-send-email-olivier.guiter@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
Hi Olivier,
On 03/24/2011 10:29 AM, Olivier Guiter wrote:
> ---
> src/emulator.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 56 insertions(+), 1 deletions(-)
>
I applied this patch, however...
<snip>
> + case G_AT_SERVER_REQUEST_TYPE_QUERY:
> + g_at_server_send_info(server, "000", TRUE);
This seems fishy to me. Shouldn't this be X: 0?
> + g_at_server_send_final(server, G_AT_SERVER_RESULT_OK);
> + break;
<snip>
Regards,
-Denis
next prev parent reply other threads:[~2011-03-25 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 15:29 [PATCH] dun: Add ATX command in emulator (X0 only) Olivier Guiter
2011-03-25 17:36 ` Denis Kenzior [this message]
2011-03-28 7:49 ` Olivier Guiter
2011-03-28 16:20 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8CD29B.70500@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.