Re: [PATCH 1/2] voicecall: add ofono_voicecall_en_list_notify api

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

Hi Jeevaka,

On 03/25/2011 09:08 AM, Jeevaka Badrappan wrote:
> ---
>  include/voicecall.h |    3 +++

Please break this up into two patches.

>  src/voicecall.c     |   12 ++++++++++++
>  2 files changed, 15 insertions(+), 0 deletions(-)
> 

<snip>

> +void ofono_voicecall_en_list_notify(struct ofono_voicecall *vc,
> +					GSList *new_en_list)
> +{
> +	GSList *l;
> +
> +	for (l = new_en_list; l; l = l->next)
> +		vc->new_en_list = g_slist_prepend(vc->new_en_list,
> +							g_strdup(l->data));

The pure 27.007 version of this function assumes that the en set is
being signaled by the cell tower.  This set needs to be union-ed with
the set obtained from the sim.

Likely you will need to track the sim list separately from the one
obtained from the cell tower and remove any duplicates.

> +
> +	set_new_ecc(vc);
> +}
> +
>  int ofono_voicecall_driver_register(const struct ofono_voicecall_driver *d)
>  {
>  	DBG("driver: %p, name: %s", d, d->name);

Regards,
-Denis