From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Q3FvE-0006jb-BE for mharc-grub-devel@gnu.org; Fri, 25 Mar 2011 18:56:00 -0400 Received: from [140.186.70.92] (port=56561 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3FvB-0006j5-Qu for grub-devel@gnu.org; Fri, 25 Mar 2011 18:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q3FvA-0000Bu-C0 for grub-devel@gnu.org; Fri, 25 Mar 2011 18:55:57 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:63470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q3FvA-0000Bb-7j for grub-devel@gnu.org; Fri, 25 Mar 2011 18:55:56 -0400 Received: by wwb39 with SMTP id 39so1121884wwb.30 for ; Fri, 25 Mar 2011 15:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type; bh=8acFVeerpYD9zW7QLvNV316ib8I16EIl2bqHhFtm5ew=; b=gR/nF6iMCZlMRGJs5QYqYGWUaM+8NvCKnJtByk47jRJHe7zpUXmXrhIM4fQz2XBvT2 fdqoyyacAWGlSvULCaEvzMnfWk7BzoEJQNXWOt9v1AUM9PMVjplBGrMwrfc0IAK8n3Gc ipgp69nY/LwnrJzfJ91T1Ijczc3ZqvXmIPrgA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; b=SFsgjJVd9PgLOzMFzqtf90+aAXrjN9lXzQ2aAEBk2ctmIleMw8WvqGF4MJ8yXtQtqu IKAQX96IZs5ets3eLiDJO9XmPwMPexMqN8oFJPW9OmPVQYhVxnUXqcJuZXZ9iJpPFgP9 gJ9hlpt+UDP/e/3GXSaEqeKc0jGhSbSNdQ6Q4= Received: by 10.227.195.143 with SMTP id ec15mr1296340wbb.213.1301093754889; Fri, 25 Mar 2011 15:55:54 -0700 (PDT) Received: from debian.x201.phnet (gprs37.swisscom-mobile.ch [193.247.250.37]) by mx.google.com with ESMTPS id e13sm671917wbi.23.2011.03.25.15.55.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Mar 2011 15:55:53 -0700 (PDT) Message-ID: <4D8D1D64.2040801@gmail.com> Date: Fri, 25 Mar 2011 23:55:32 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110303 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Mario Limonciello References: <4D8D1397.5030802@dell.com> In-Reply-To: <4D8D1397.5030802@dell.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8AF046B72BA682BC131C992F" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 Cc: grub-devel@gnu.org, Colin Watson Subject: Re: [PATCH] grub-setup Modify the conditionality of the copy of the partition table X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 22:55:58 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8AF046B72BA682BC131C992F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 25.03.2011 23:13, Mario Limonciello wrote: > + * util/grub-setup.c: Conditionalize the partition map copy on = floppy > + support, not on whether the target contains partitions. > + > + Otherwise, the BIOS on Dell Latitude E series laptops will f= reeze=20 > + during POST if an invalid partition table is contained in th= e PBR > + of the active partition when GRUB is installed to a partitio= n. It's wrong to assume that no floppies contain partition tables. Also --allow-floppy is usually used for USB sticks which sometimes appear as floppies on some BIOSes and they pretty much contain the partition table. Bottom line is: if you see a partition table: preserve it. But it's ok to preserve this contents if floppy support is disabled even if no partition table is discovered. A small logic lecture: Floppy support is: allow_floppy || grub_util_biosdisk_is_floppy (dest_dev= ->disk) Negation of it is either !(allow_floppy || grub_util_biosdisk_is_floppy (= dest_dev->disk)) or !allow_floppy && !grub_util_biosdisk_is_floppy (dest_= dev->disk), not what you wrote. Please don't move around unrelated parts. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8AF046B72BA682BC131C992F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk2NHWQACgkQNak7dOguQgl0OAD/dulvJevFAFRDsU0fn5SDecTF XXDnuTEZUjVuF8dx+2EBALjSQIk+Oj9PKJESfCfEtJfcAVyojO7UMldweDY1RZzJ =+zc4 -----END PGP SIGNATURE----- --------------enig8AF046B72BA682BC131C992F--