From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-watchdog-owner@vger.kernel.org>
Received: from rcsinet10.oracle.com ([148.87.113.121]:35630 "EHLO
	rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755505Ab1CZBnP (ORCPT
	<rfc822;linux-watchdog@vger.kernel.org>);
	Fri, 25 Mar 2011 21:43:15 -0400
Message-ID: <4D8D44A7.6060605@oracle.com>
Date: Fri, 25 Mar 2011 18:43:03 -0700
From: Randy Dunlap <randy.dunlap@oracle.com>
MIME-Version: 1.0
To: Mike Waychison <mikew@google.com>
CC: lkml <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>,
	Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: fix nv_tco section mismatch
References: <20110324133244.acffd99a.randy.dunlap@oracle.com> <AANLkTikLSVpw73r_g++_oRs=nTjYf5WmH=XNjjp8o5uo@mail.gmail.com>
In-Reply-To: <AANLkTikLSVpw73r_g++_oRs=nTjYf5WmH=XNjjp8o5uo@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-watchdog-owner@vger.kernel.org
List-Id: linux-watchdog@vger.kernel.org

On 03/25/11 16:42, Mike Waychison wrote:
> On Thu, Mar 24, 2011 at 1:32 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix section mismatch warning:
>> Mark the called nv_tco_getdevice() as __devinit, just like its caller.
> 
> This looks fine.
> 
> I can't seem to reproduce the warning on my end however, compiling
> this as a built-in nor as a module.  How do I trigger a difference
> between __init and __devinit?

I just used allmodconfig.  But why wouldn't you see a differnence between
__init and __devinit?  They are defined differently in include/linux/init.h,
but maybe on some $arch, those sections are treated differently?

I dunno.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***