From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 11/13] KVM: SVM: Add intercept checks for one-byte instructions
Date: Sat, 26 Mar 2011 11:53:14 +0200
Message-ID: <4D8DB78A.5030209@redhat.com>
References: <1301045356-25257-1-git-send-email-joerg.roedel@amd.com> <1301045356-25257-12-git-send-email-joerg.roedel@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:39389 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752586Ab1CZJxT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 26 Mar 2011 05:53:19 -0400
In-Reply-To: <1301045356-25257-12-git-send-email-joerg.roedel@amd.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 03/25/2011 11:29 AM, Joerg Roedel wrote:
> This patch add intercept checks for emulated one-byte
> instructions to the KVM instruction emulation path.
>
>
>   #undef PRE_EX
> @@ -3990,6 +3997,13 @@ static int svm_check_intercept(struct kvm_vcpu *vcpu,
>   		else
>   			vmcb->control.exit_info_1 = 0;
>   		break;
> +	case SVM_EXIT_PAUSE:
> +		/*
> +		 * We get this for NOP only, but pause
> +		 * is rep not, check this here
> +		 */
> +		if (info->rep_prefix != REPE_PREFIX)
> +			goto out;

Eventually we'll have decode table support for REP prefix (for mmx/sse 
instructions) so this will go away too.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.