From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============4262057334073589989=="
MIME-Version: 1.0
From: Olivier Guiter <olivier.guiter@linux.intel.com>
Subject: Re: [PATCH] dun: Add ATX command in emulator (X0 only)
Date: Mon, 28 Mar 2011 09:49:48 +0200
Message-ID: <4D903D9C.6000907@linux.intel.com>
In-Reply-To: <4D8CD29B.70500@gmail.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============4262057334073589989==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On 03/25/2011 06:36 PM, Denis Kenzior wrote:
> Hi Olivier,
>
> On 03/24/2011 10:29 AM, Olivier Guiter wrote:
>> ---
>>   src/emulator.c |   57 ++++++++++++++++++++++++++++++++++++++++++++++++=
+++++++-
>>   1 files changed, 56 insertions(+), 1 deletions(-)
>>
> I applied this patch, however...
>
> <snip>
>
>> +	case G_AT_SERVER_REQUEST_TYPE_QUERY:
>> +		g_at_server_send_info(server, "000", TRUE);
> This seems fishy to me.  Shouldn't this be X: 0?
>
>> +		g_at_server_send_final(server, G_AT_SERVER_RESULT_OK);
>> +		break;
> <snip>
>
> Regards,
> -Denis
It should be ;) but i tried to keep the answer format consistent with =

other AT command answers... Maybe i m wrong ?
Olivier



--===============4262057334073589989==--