From: Avi Kivity <avi@redhat.com>
To: Wei Xu <wexu2@cisco.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: "KVM internal error. Suberror: 1" with ancient 2.4 kernel as guest
Date: Mon, 28 Mar 2011 11:23:27 +0200 [thread overview]
Message-ID: <4D90538F.5060901@redhat.com> (raw)
In-Reply-To: <C9B52A02.2B83A%wexu2@cisco.com>
On 03/28/2011 02:53 AM, Wei Xu wrote:
> >> +++ linux/contents/include/linux/kvm.h 2011-03-21 09:16:39.000000000 -0700
> >> @@ -152,7 +152,7 @@
> >> /* KVM_EXIT_MMIO */
> >> struct {
> >> __u64 phys_addr;
> >> - __u8 data[8];
> >> + __u8 data[16];
> >> __u32 len;
> >> __u8 is_write;
> >> } mmio;
> >
> > This breaks the userspace interface. My implementation split the I/O
> > into two separate 64-bit writes.
>
> Wei>>It will not break the user interface -- the "len" tells user space qemu
> how many bytes need to be copied; and qemu mmio logic can handle more than
> 64-bit writes.
But the location of the 'len' field changes. You have to recompile your
userspace so the code is aware of the new location.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-03-28 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 14:32 "KVM internal error. Suberror: 1" with ancient 2.4 kernel as guest Jiri Kosina
2010-08-31 15:49 ` Avi Kivity
2010-08-31 16:30 ` Avi Kivity
2011-03-21 21:23 ` Wei Xu
2011-03-22 10:54 ` Jiri Kosina
2011-03-25 22:12 ` Wei Xu
2011-03-27 11:57 ` Avi Kivity
2011-03-28 0:53 ` Wei Xu
2011-03-28 9:23 ` Avi Kivity [this message]
2011-03-28 16:31 ` Wei Xu
2011-03-28 16:33 ` Avi Kivity
2011-03-28 16:36 ` Wei Xu
2011-03-28 0:54 ` Wei Xu
2011-03-28 9:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D90538F.5060901@redhat.com \
--to=avi@redhat.com \
--cc=jkosina@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=wexu2@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.