All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: xen kernel headers: circular dependencies
Date: Mon, 28 Mar 2011 11:56:42 +0200	[thread overview]
Message-ID: <4D905B5A.50209@amd.com> (raw)


Hi,

I just uncovered a circular header dependency starting from
_PAGE_NX.

_PAGE_NX is defined in asm-x86/x86_{64,32}/page.h and uses cpu_has_nx
cpu_has_nx is defined in asm-x86/cpufeature.h.

So make asm-x86/x86_{64,32}/page.h include <asm/cpufeature.h>

cpufeature.h uses boot_cpu_data which is declared in asm-x86/processor.h

So make cpufeature.h include <asm/processor.h>

processor.h uses NCAPINTS which is defined in cpufeature.h

processor.h already includes cpufeature.h


gcc fails to build with complaining about implicit declaration of 
function 'get_cpu_info' then.


Any suggestions on how to fix this?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

             reply	other threads:[~2011-03-28  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28  9:56 Christoph Egger [this message]
2011-03-28 12:46 ` xen kernel headers: circular dependencies Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D905B5A.50209@amd.com \
    --to=christoph.egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.