From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 10/13] KVM: SVM: Add intercept checks for remaining twobyte instructions Date: Mon, 28 Mar 2011 14:29:18 +0200 Message-ID: <4D907F1E.2080903@redhat.com> References: <1301309210-11120-1-git-send-email-joerg.roedel@amd.com> <1301309210-11120-11-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17676 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008Ab1C1M3W (ORCPT ); Mon, 28 Mar 2011 08:29:22 -0400 In-Reply-To: <1301309210-11120-11-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/28/2011 12:46 PM, Joerg Roedel wrote: > This patch adds intercepts checks for the remaining twobyte > instructions to the KVM instruction emulator. > > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index e0eed4c..4a5881d 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2570,8 +2570,8 @@ static struct opcode twobyte_table[256] = { > N, N, N, N, > N, N, N, N, N, N, N, N, > /* 0x30 - 0x3F */ > - D(ImplicitOps | Priv), II(ImplicitOps, em_rdtsc, rdtsc), > - D(ImplicitOps | Priv), N, > + DI(ImplicitOps | Priv, wrmsr), II(ImplicitOps, em_rdtsc, rdtsc), cr4.tsd check > + DI(ImplicitOps | Priv, rdmsr), DI(ImplicitOps | Priv, rdpmc), Not privileged if cr4.pce=1. -- error compiling committee.c: too many arguments to function