From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42362 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4FB8-0005uo-9l
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 12:20:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Q4FB2-0003gn-TW
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 12:20:26 -0400
Received: from moutng.kundenserver.de ([212.227.126.171]:54581)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Q4FB2-0003gV-IW
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 12:20:24 -0400
Message-ID: <4D90B53F.8070708@mail.berlios.de>
Date: Mon, 28 Mar 2011 18:20:15 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset
References: <1301176389-14253-1-git-send-email-weil@mail.berlios.de>
	<20110328021753.GB16639@valinux.co.jp>
	<4D901A0C.3090705@mail.berlios.de>
	<20110328052511.GC16639@valinux.co.jp>
	<m3pqpba9d8.fsf@blackfin.pond.sub.org>
	<20110328092450.GE16639@valinux.co.jp>
In-Reply-To: <20110328092450.GE16639@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Am 28.03.2011 11:24, schrieb Isaku Yamahata:
> On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote:
>> Isaku Yamahata <yamahata@valinux.co.jp> writes:
>>
>>> On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote:
>>>> Am 28.03.2011 04:17, schrieb Isaku Yamahata:
>> [...]
>>>>> On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote:
>>>>>> cirrus_reset is also called by the pci framework,
>>>>>> so there is no need to call it in cirrus_init_common.
>>>>>>
>>>>>> Cc: Michael S. Tsirkin<mst@redhat.com>
>>>>>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>> [...]
>>>> I tested the new code with isa pc, too. In gdb, I could see that it 
>>>> also
>>>> calls
>>>> cirrus_reset twice. But isa pc is broken since the switch to sea 
>>>> bios, so
>>>> obviously isa is an unmaintained part of qemu. Even with bochs bios,
>>>> it no longer works, so it is broken at least twice.
>>>
>>> Ah, I see. The the second reset is called not via pci reset framework,
>>> but qemu reset framework. So removing the above reset call makes sense.
>>> It would be another patch to make use of pci reset framework.
>>
>> Then the proposed commit message's claim cirrus_reset() is "called by
>> the pci framework" is incorrect, isn't it?
>
> Yes, incorrect. The commit message should be fixed.
> The code change itself looks correct.

For current qemu it is correct, or is there a working configuration
with isa cirrus? I asked that question on #qemu but did not get
an answer (Anthony replied that isa was broken long ago).

This was the reason why I wrote the commit text as it is.
I don't mind if the committer adds more descriptive text,
but the main focus should be fixing isa emulation.
I also noticed that some more emulations obviously also
include redundant reset calls. These should be fixed, too.