From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id C2363B6FA3 for ; Tue, 29 Mar 2011 04:40:12 +1100 (EST) Received: by wyg36 with SMTP id 36so2669328wyg.38 for ; Mon, 28 Mar 2011 10:40:08 -0700 (PDT) Message-ID: <4D90C78C.3050607@ru.mvista.com> Date: Mon, 28 Mar 2011 21:38:20 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Tirumala Marri Subject: Re: [PATCH V9 10/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile References: <1297119242-28562-1-git-send-email-tmarri@apm.com> <4D518B2D.3090603@ru.mvista.com> <5540911d2e000414054d989bbdc32f2c@mail.gmail.com> In-Reply-To: <5540911d2e000414054d989bbdc32f2c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Sergei Shtylyov , greg@kroah.com, linux-usb@vger.kernel.org, Mark Miesfeld , linuxppc-dev@lists.ozlabs.org, Fushen Chen List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. Tirumala Marri wrote: >>> +config DWC_DEVICE_ONLY >>> + bool "DWC Device Only Mode" >>> + select USB_GADGET_SELECTED >>> + >>> +endchoice >> So this is tri-modal driver after all... how come we place it in >> drivers/usb/otg/dwc/, while the same tri-modal MUSB driver was placed in >> drivers/usb/musb/? You still have quoting broken in your mailer -- I've fixed it up by hand... > [Marri] Initially this was how the patch created. Greg KH, suggested to > move under OTG. Well, I know that. So this was a question to Greg... WBR, Sergei