All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ángel González" <ingenit@zoho.com>
To: Maxin john <maxin@maxinbjohn.info>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Lukas Sandström" <luksan@gmail.com>
Subject: Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh
Date: Tue, 29 Mar 2011 02:16:00 +0200	[thread overview]
Message-ID: <4D9124C0.8070003@zoho.com> (raw)
In-Reply-To: <AANLkTin-USDnTxeKT_KOZW5kgC0vFXYbMNP9ct6fzbUC@mail.gmail.com>

Maxin john wrote:
> > Remove "bashism" and minor corrections for
> > contrib/thunderbird-patch-inline/appp.sh
> >
> > Signed-off-by: Maxin B. John <maxin@maxinbjohn.info>
This is wrong.

You are replacing bash with sh:
> > -#!/bin/bash
> > +#!/bin/sh

but the script still uses bash-specific syntax (aka. bashishms):
> > +
> >  PATCH=$(zenity --file-selection)
> >
> >  if [ "$?" != "0" ] ; then

So with your change the script won't be able to run on systems which
don't have bash as /bin/sh

The standard equivalent of $( ) are `backticks`.

  parent reply	other threads:[~2011-03-29  0:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-27 14:37 [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh Maxin john
2011-03-28 21:55 ` Ángel González
2011-03-29  6:54   ` Maxin john
2011-03-29  7:09   ` Junio C Hamano
2011-03-29 22:48     ` Ángel González
2011-03-30  8:52       ` Maxin john
2011-03-30 17:57         ` Junio C Hamano
2011-03-30 18:51           ` Maxin john
2011-03-31 21:56         ` Junio C Hamano
     [not found]   ` <8721039.4955.1301382568626.JavaMail.trustmail@mail1.terreactive.ch>
2011-03-29 14:03     ` Victor Engmark
2011-03-29  0:16 ` Ángel González [this message]
2011-03-29  1:01 ` Junio C Hamano
2011-03-29  6:47   ` Maxin john

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9124C0.8070003@zoho.com \
    --to=ingenit@zoho.com \
    --cc=git@vger.kernel.org \
    --cc=luksan@gmail.com \
    --cc=maxin@maxinbjohn.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.