From: Donghwa Lee <dh09.lee@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [patch] backlight/ld9040.c: testing the wrong variable in
Date: Tue, 29 Mar 2011 04:37:12 +0000 [thread overview]
Message-ID: <4D9161F8.3050004@samsung.com> (raw)
In-Reply-To: <20110329031909.GC9856@bicker>
On 2011-03-29, Dan Carpenter wrote:
> We should be testing "bd" here instead of "ld". It's a copy and
> paste bug.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
> index 7281b25..9e81d69 100644
> --- a/drivers/video/backlight/ld9040.c
> +++ b/drivers/video/backlight/ld9040.c
> @@ -701,8 +701,8 @@ static int ld9040_probe(struct spi_device *spi)
>
> bd = backlight_device_register("ld9040-bl", &spi->dev,
> lcd, &ld9040_backlight_ops, NULL);
> - if (IS_ERR(ld)) {
> - ret = PTR_ERR(ld);
> + if (IS_ERR(bd)) {
> + ret = PTR_ERR(bd);
> goto out_free_lcd;
> }
>
>
Yes, It's my mistake. It has to be changed as you said.
Thank you,
prev parent reply other threads:[~2011-03-29 4:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 3:19 [patch] backlight/ld9040.c: testing the wrong variable in Dan Carpenter
2011-03-29 4:37 ` Donghwa Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9161F8.3050004@samsung.com \
--to=dh09.lee@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.