Re: Please revert a91a2785b20

[Jens Axboe <jaxboe@fusionio.com>]

On 2011-03-29 01:03, Mike Snitzer wrote:
> On Mon, Mar 28 2011 at  6:43pm -0400,
> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
>> Forgot to cc Jens and fixed up the borked mail address of Mike which
>> I took from the changelog :(
>>
>> On Tue, 29 Mar 2011, Thomas Gleixner wrote:
>>
>>> Out of the blue all my perfectly fine working test machines which use
>>> RAID stopped working with the very helpful error message:
>>>
>>> 	md/raid1:md1: active with 2 out of 2 mirrors
>>> 	md: pers->run() failed ...
>>>
>>> Reverting a91a2785b20 fixes the problem.
>>>
>>> Neither the subject line:
>>>
>>>  block: Require subsystems to explicitly allocate bio_set integrity mempool
>>>
>>> nor the changelog have any hint why that wreckage is in any way
>>> sensible.
>>>
>>> The wreckage happens due to:
>>>
>>> -       md_integrity_register(mddev);
>>> -       return 0;
>>> +       return md_integrity_register(mddev);
> 
> Right, a kernel.org BZ was filed on this here:
> https://bugzilla.kernel.org/show_bug.cgi?id=32062
> 
> Martin is working to "conjure up a patch" to fix the common case where
> no devices in the MD have DIF/DIX capabilities.

And I see that has been merged now. So all is good?

-- 
Jens Axboe