From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: KVM: x86: vcpu state writeback should be aware of REQ_NMI
Date: Tue, 29 Mar 2011 15:36:04 +0200 [thread overview]
Message-ID: <4D91E044.7080400@redhat.com> (raw)
In-Reply-To: <20110329131249.GA2675@amt.cnet>
On 03/29/2011 03:12 PM, Marcelo Tosatti wrote:
> On Thu, Mar 24, 2011 at 05:35:27PM +0200, Avi Kivity wrote:
> > On 03/24/2011 05:19 PM, Gleb Natapov wrote:
> > >> Two patches one to revert REQ_NMI then another to fix the original problem
> > >> makes backporting easier.
> > >If we agree this is the way to go will do that.
> > >
> >
> > Not sure, want to think about it for a bit.
>
> Ping?
>
I think Gleb's approach is better. ->requests is fine for notifications
but not for state.
I'd like to see ACCESS_ONCE() semantics for the vcpu variable, so we
don't introduce races, even if they are benign. A problem with benign
races is that you have to re-think about them later to be sure they are
still benign.
We also need to document which vcpu variables are asynchronous.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-03-29 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 12:47 KVM: x86: vcpu state writeback should be aware of REQ_NMI Marcelo Tosatti
2011-03-24 13:26 ` Avi Kivity
2011-03-24 13:27 ` Gleb Natapov
2011-03-24 13:33 ` Avi Kivity
2011-03-24 13:38 ` Gleb Natapov
2011-03-24 14:59 ` Marcelo Tosatti
2011-03-24 15:19 ` Gleb Natapov
2011-03-24 15:35 ` Avi Kivity
2011-03-29 13:12 ` Marcelo Tosatti
2011-03-29 13:36 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D91E044.7080400@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.