Re: [PATCH v2 1/4] include: Add ofono_voicecall_en_list_notify api

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

Hi Jeevaka,

On 03/28/2011 08:58 AM, Jeevaka Badrappan wrote:
> ---
>  include/voicecall.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/voicecall.h b/include/voicecall.h
> index 5e6da02..477b226 100644
> --- a/include/voicecall.h
> +++ b/include/voicecall.h
> @@ -140,6 +140,9 @@ struct ofono_voicecall_driver {
>  			ofono_voicecall_cb_t cb, void *data);
>  };
>  
> +void ofono_voicecall_en_list_notify(struct ofono_voicecall *vc,
> +					GSList *nw_en_list);
> +

We have a long-standing rule not to introduce G* types into the oFono
public API.  For lists, please use an array of strings for this.  Refer
to e.g. ofono_netreg_operator_list_cb_t or similar for an example.

>  void ofono_voicecall_notify(struct ofono_voicecall *vc,
>  				const struct ofono_call *call);
>  void ofono_voicecall_disconnected(struct ofono_voicecall *vc, int id,

Regards,
-Denis