All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] isimodem: fix operator name reading with old ISI modems
Date: Tue, 29 Mar 2011 22:27:11 -0500	[thread overview]
Message-ID: <4D92A30F.1040507@gmail.com> (raw)
In-Reply-To: <1301385254-28543-2-git-send-email-mika.liljeberg@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi Mika,

> @@ -466,7 +466,8 @@ static void name_get_resp_cb(const GIsiMessage *msg, void *data)
>  
>  	memset(&op, 0, sizeof(struct ofono_network_operator));
>  
> -	if (!check_response_status(msg, NET_OPER_NAME_READ_RESP))
> +	if (!check_response_status(msg, NET_OPER_NAME_READ_RESP) &&
> +		!check_response_status(msg, NET_OLD_OPER_NAME_READ_RESP))

doc/coding-style.txt item M4

>  		goto error;
>  
>  	for (g_isi_sb_iter_init(&iter, msg, 6);

Regards,
-Denis

  reply	other threads:[~2011-03-30  3:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH 0/1] fix operator name reading with old ISI modems>
2011-03-29  7:54 ` Mika Liljeberg
2011-03-29  7:54 ` [PATCH 1/1] isimodem: fix operator name reading with old ISI modems Mika Liljeberg
2011-03-30  3:27   ` Denis Kenzior [this message]
2011-03-31  8:35 [TAKE 2] " Mika Liljeberg
2011-03-31  8:35 ` [PATCH 1/1] " Mika Liljeberg
2011-03-31 15:27   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D92A30F.1040507@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.