From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============2268482661908755602=="
MIME-Version: 1.0
From: Denis Kenzior <denkenz@gmail.com>
Subject: Re: [PATCH] emulator: add AT hook_control_cb() CB and register it
Date: Tue, 29 Mar 2011 22:49:39 -0500
Message-ID: <4D92A853.7000002@gmail.com>
In-Reply-To: <1300962329-24257-1-git-send-email-guillaume.zajac@linux.intel.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============2268482661908755602==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Guillaume,

On 03/24/2011 05:25 AM, Guillaume Zajac wrote:
> ---
>  src/emulator.c |   44 +++++++++++++++++++++++++++++++++++++++++---
>  1 files changed, 41 insertions(+), 3 deletions(-)
> =

> diff --git a/src/emulator.c b/src/emulator.c
> index c84f0a9..586c7ec 100644
> --- a/src/emulator.c
> +++ b/src/emulator.c
> @@ -177,6 +177,41 @@ error:
>  	g_at_server_send_final(em->server, G_AT_SERVER_RESULT_ERROR);
>  }
>  =

> +static void hook_control_cb(GAtServer *server, GAtServerRequestType type,

Can you rename this dun_ath_cb, since this is pretty much dun specific

> +			GAtResult *result, gpointer user_data)
> +{
> +	struct ofono_emulator *em =3D user_data;
> +	GAtResultIter iter;
> +	int val;
> +
> +	DBG("");
> +
> +	if (type !=3D G_AT_SERVER_REQUEST_TYPE_SET)
> +		goto error;

Wouldn't we be also getting G_AT_SERVER_REQUEST_TYPE_COMMAND_ONLY here?

> +
> +	if (em->ppp =3D=3D NULL)
> +		goto error;
> +
> +	g_at_result_iter_init(&iter, result);
> +	g_at_result_iter_next(&iter, "");
> +
> +	if (g_at_result_iter_next_number(&iter, &val) =3D=3D FALSE)
> +		goto error;
> +
> +	if (val !=3D 0)
> +		goto error;
> +
> +	g_at_ppp_unref(em->ppp);
> +	em->ppp =3D NULL;
> +
> +	g_at_server_send_final(server, G_AT_SERVER_RESULT_OK);
> +
> +	return;
> +
> +error:
> +	g_at_server_send_final(server, G_AT_SERVER_RESULT_ERROR);
> +}
> +
>  static void brsf_cb(GAtServer *server, GAtServerRequestType type,
>  			GAtResult *result, gpointer user_data)
>  {
> @@ -466,10 +501,13 @@ void ofono_emulator_register(struct ofono_emulator =
*em, int fd)
>  =

>  	__ofono_atom_register(em->atom, emulator_unregister);
>  =

> -	if (em->type =3D=3D OFONO_EMULATOR_TYPE_DUN)
> +	if (em->type =3D=3D OFONO_EMULATOR_TYPE_DUN) {
>  		g_at_server_register(em->server, "D", dial_cb, em, NULL);
> -	else if (em->type =3D=3D OFONO_EMULATOR_TYPE_HFP)
> -		g_at_server_set_echo(em->server, FALSE);
> +		g_at_server_register(em->server, "H", hook_control_cb, em, NULL);
> +	} else {
> +		if (em->type =3D=3D OFONO_EMULATOR_TYPE_HFP)
> +			g_at_server_set_echo(em->server, FALSE);

I'd really prefer this to use a switch/case statement.

> +	}
>  }
>  =

>  static void emulator_remove(struct ofono_atom *atom)

Regards,
-Denis

--===============2268482661908755602==--