From: Daniel Hellstrom <daniel@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ Controller
Date: Wed, 30 Mar 2011 12:41:45 +0000 [thread overview]
Message-ID: <4D932509.70700@gaisler.com> (raw)
In-Reply-To: <1300290864-20678-1-git-send-email-daniel@gaisler.com>
David Miller wrote:
>From: Daniel Hellstrom <daniel@gaisler.com>
>Date: Wed, 30 Mar 2011 12:00:53 +0200
>
>
>
>>Yes, I agree with you that this is the best solution. However, the
>>hardware simply does not support that. That would require the
>>bootloader to have one driver per core and that the bootloader must be
>>modified each time a user of LEON or gaisler adds a new core.
>>
>>I have made another patch that creates all 0..15 IRQs on startup
>>instead in leon_kernel.c. It will ensure linearity within that range,
>>and patching of irq_32.c is not needed. Perhaps that is more
>>acceptable?
>>
>>
>
>I am not asking you to modify the boot loader or whatever creates
>the firmware device tree on LEON.
>
>I'm telling you to modify the kernel to create device node objects
>which have an array of multiple IRQ entries when such devices are
>found during the import of the device tree.
>
>
I see, however that is almost as bad because that would also require one
driver per core but in the LEON IRQ layer of Linux.
If I always create an array of say 8 IRQs starting from the first IRQ,
for example for IRQ5: {5,6,7,8,9,10,11,12}, that would be a solution for
the drivers as well. 8 IRQs should be enough per core. That would
however require that I change the scan_one_device() (of_device_32.c) and
add an extra call to sparc_irq_config structure, fixup_device_irqs() or
prepare_device_irqs() or something like that. This will result in
devices with an archdata.irqs[] containing unused IRQs that are not
really available. Do you think this is an acceptable solution?
Daniel
next prev parent reply other threads:[~2011-03-30 12:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 15:54 [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ Controller Daniel Hellstrom
2011-03-30 9:23 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ David Miller
2011-03-30 10:00 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ Controller Daniel Hellstrom
2011-03-30 10:34 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ David Miller
2011-03-30 12:41 ` Daniel Hellstrom [this message]
2011-03-30 22:41 ` David Miller
2011-03-31 15:13 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ Controller Daniel Hellstrom
2011-03-31 23:57 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ David Miller
2011-04-01 8:17 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ Controller Daniel Hellstrom
2011-04-11 15:30 ` Daniel Hellstrom
2011-04-11 19:59 ` [PATCH] sparc32,leon: need VIRQ:IRQ 1:1, don't mask/ack IRQ David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D932509.70700@gaisler.com \
--to=daniel@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.