From: Philip Prindeville <philipp_subx@redfish-solutions.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Use VPI.VCI notation uniformly.
Date: Wed, 30 Mar 2011 17:17:58 -0600 [thread overview]
Message-ID: <4D93BA26.2010405@redfish-solutions.com> (raw)
In-Reply-To: <20110330.160358.55865087.davem@davemloft.net>
On 3/30/11 5:03 PM, David Miller wrote:
> From: Philip Prindeville <philipp_subx@redfish-solutions.com>
> Date: Wed, 30 Mar 2011 16:56:27 -0600
>
>> From: Philip A. Prindeville <philipp@redfish-solutions.com>
>>
>> Use VPI.VCI notation consistently throughout the module. This is the
>> one remaining place where the VCI is used before the VPI in any output.
>>
>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
>> ---
>> drivers/atm/solos-pci.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
> Why do your subject lines not have an appropriate prefix?
>
> How will someone scanning the commit header lines in the tree know
> that this is a change to the solos-pci driver unless you prefix
> them with "solos-pci: " or similar?
It was an oversight. Want me to resubmit?
prev parent reply other threads:[~2011-03-30 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 22:56 [PATCH 1/2] Use VPI.VCI notation uniformly Philip Prindeville
2011-03-30 23:03 ` David Miller
2011-03-30 23:17 ` Philip Prindeville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D93BA26.2010405@redfish-solutions.com \
--to=philipp_subx@redfish-solutions.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.