From: Christopher Heiny <cheiny@synaptics.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Allie Xiong <axiong@synaptics.com>,
William Manson <WManson@synaptics.com>,
Joerie de Gram <j.de.gram@gmail.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>
Subject: Re: [PATCH 0/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver
Date: Wed, 30 Mar 2011 19:35:09 -0700 [thread overview]
Message-ID: <4D93E85D.6080204@synaptics.com> (raw)
In-Reply-To: <20110330200238.GA9493@core.coreip.homeip.net>
On 03/30/2011 01:02 PM, Dmitry Torokhov wrote:
> Hi Chris,
>
> On Wed, Mar 30, 2011 at 07:05:24AM -0700, Christopher Heiny wrote:
>> This patch implements a driver supporting Synaptics ClearPad and other
>> touchscreens that use the RMI4 protocol, as defined here:
>>
>> http://www.synaptics.com/sites/default/files/511-000136-01_revD.pdf
>>
>> This patch is against the v2.6.38 tag of Linus' kernel tree, commit
>> 521cb40b0c44418a4fd36dc633f575813d59a43d. Note that previous patches
>> were against the synaptics-rmi4 branch of Dmitry Torokhov's input
>> tree. At Dmitry's request, we have switched the base for our work
>> to v2.6.38 - this should make it easier for people to pick up and
>> test this and future patches.
>>
>
> The source as sumitted is quite "dirty" i.e. littered with multiple #if
> 0...#endif etc. Cooudl you please clean it up and resubmit so that
> unneeded details/code would not get into the way of reviiewing the
> driver?
I've done some tidy up. Two #if 0's still exist, surrounding code that
causes problems on some dev systems. The remaining #if 0's have been
removed or converted to a more conventional and compact approach that
shouldn't interfere with understanding the code.
I've also removed a bunch of extraneous printks.
Patch to follow in a few minutes.
Chris
next prev parent reply other threads:[~2011-03-31 2:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 14:05 [PATCH 0/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver Christopher Heiny
2011-03-30 14:05 ` [PATCH 1/3] (corrected) " Christopher Heiny
2011-03-30 14:05 ` [PATCH 2/3] " Christopher Heiny
2011-03-30 14:05 ` [PATCH 3/3] " Christopher Heiny
2011-03-30 20:02 ` [PATCH 0/3] " Dmitry Torokhov
2011-03-30 20:49 ` Christopher Heiny
2011-03-31 2:35 ` Christopher Heiny [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-30 0:50 Christopher Heiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D93E85D.6080204@synaptics.com \
--to=cheiny@synaptics.com \
--cc=WManson@synaptics.com \
--cc=axiong@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=j.de.gram@gmail.com \
--cc=khali@linux-fr.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.