All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, Justin Forbes <jforbes@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] exit if -drive specified is invalid instead of ignoring the "wrong" -drive
Date: Thu, 31 Mar 2011 12:47:24 +0200	[thread overview]
Message-ID: <4D945BBC.4060104@redhat.com> (raw)
In-Reply-To: <1301488265-22028-1-git-send-email-mjt@msgid.tls.msk.ru>

Am 30.03.2011 14:31, schrieb Michael Tokarev:
> This fixes the problem when qemu continues even if -drive specification
> is somehow invalid, resulting in a mess.  Applicable for both current
> master and for stable-0.14 (and the same issue exist 0.13 and 0.12 too).
> 
> The prob can actually be seriuos: when you start guest with two drives
> and make an error in the specification of one of them, and the guest
> has something like a raid array on the two drives, guest may start failing
> that array or kick "missing" drives which may result in a mess - this is
> what actually happened to me, I did't want a resync at all, and a resync
> resulted in re-writing (and allocating) a 4TB virtual drive I used for
> testing, which in turn resulted in my filesystem filling up and whole
> thing failing badly.  Yes it was just testing VM, I experimented with
> larger raid arrays, but the end result was quite, well, unexpected.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Thanks, applied to the block branch. CCed Justin for stable.

Kevin

      parent reply	other threads:[~2011-03-31 10:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 12:31 [Qemu-devel] [PATCH] exit if -drive specified is invalid instead of ignoring the "wrong" -drive Michael Tokarev
2011-03-30 13:08 ` Jes Sorensen
2011-03-30 13:22   ` Michael Tokarev
2011-03-30 13:33     ` Jes Sorensen
2011-03-31 10:47 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D945BBC.4060104@redhat.com \
    --to=kwolf@redhat.com \
    --cc=jforbes@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.